Repository navigation
Conversation
wrenix
reviewed
Nov 12, 2026
wrenix
left a comment
Collaborator
There was a problem hiding this comment.
I do not understand the worth of this PR/patch, your Issue looks AI generated and overblown ...
| livenessProbe: | ||
| httpGet: | ||
| path: /status.php | ||
| path: {{ .path | default "/status.php" }} |
Collaborator
There was a problem hiding this comment.
please do not put defaults to template, therefore the values.yaml exists.
Expose configurable HTTP GET path for liveness, readiness, and startup probes in deployment.yaml and values.yaml, defaulting to /status.php for full backward compatibility. Fixes nextcloud#890 Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
MishowHD
force-pushed
the
feat/configurable-probe-paths
branch
from
November 12, 2026 23:56
60a62fb to
c964101
Compare
Author
|
wrenix thanks for the comment. I used the ai to write the description of the pr, but the issue is not mine, I contributed to solve it. I fixed the /status.php anyway |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose configurable HTTP GET path for liveness, readiness, and startup probes in deployment.yaml and values.yaml,
Fixes #890
Description of the change
Make the HTTP GET path configurable for all three container probes (
livenessProbe,readinessProbe, andstartupProbe) across both the non-nginx and nginx deployment templates.Benefits
Possible drawbacks
None.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.