Skip to content

feat(nextcloud): make probe paths configurable (#890) - #899

Open
MishowHD wants to merge 1 commit into
nextcloud:mainfrom
MishowHD:feat/configurable-probe-paths
Open

MishowHD wants to merge 1 commit into
nextcloud:mainfrom
MishowHD:feat/configurable-probe-paths

Conversation

@MishowHD

@MishowHD MishowHD commented Oct 26, 2026 •

Copy link
Copy Markdown

Expose configurable HTTP GET path for liveness, readiness, and startup probes in deployment.yaml and values.yaml,
Fixes #890

Description of the change

Make the HTTP GET path configurable for all three container probes (livenessProbe, readinessProbe, and startupProbe) across both the non-nginx and nginx deployment templates.

Benefits

  • Allows operators to decouple process liveness checks from external dependency health checks

Possible drawbacks

None.

Applicable issues

Additional information

Checklist

@wrenix wrenix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand the worth of this PR/patch, your Issue looks AI generated and overblown ...

livenessProbe:
httpGet:
path: /status.php
path: {{ .path | default "/status.php" }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not put defaults to template, therefore the values.yaml exists.

Expose configurable HTTP GET path for liveness, readiness, and startup probes in deployment.yaml and values.yaml, defaulting to /status.php for full backward compatibility.

Fixes nextcloud#890

Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
@MishowHD
MishowHD force-pushed the feat/configurable-probe-paths branch from 60a62fb to c964101 Compare November 12, 2026 23:56
@MishowHD

Copy link
Copy Markdown
Author

wrenix thanks for the comment. I used the ai to write the description of the pr, but the issue is not mine, I contributed to solve it. I fixed the /status.php anyway

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make probe paths configurable (liveness on /status.php restarts healthy pods during dependency outages)

2 participants