Repository navigation
Fix federated null-user read mark lookup for card comments - #8752
Open
mayankm00007 wants to merge 1 commit into
Open
mayankm00007 wants to merge 1 commit into
mayankm00007 wants to merge 1 commit into
Conversation
Avoid calling commentsManager::getReadMark() when no local user exists for the request, which caused 500s on federated board stacks with commented cards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mayankm00007
requested review from
grnd-alt and
luka-nextcloud
as code owners
November 16, 2026 13:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
getReadMark()when the request has no logged-in user, which happens for federated board loads. This prevents the 500 error on stacks with commented cards while preserving unread-comment tracking for real user sessions.This fix keeps the comment count, but skips the read-mark lookup and unread count calculation when
$user === null.TODO
Checklist
🤖 AI (if applicable)