Repository navigation
Conversation
Contributor
Author
|
Heads-up on one detail in this diff: the deck ExApp is being renamed from marp_slides to SlidePrepper, and the task type id follows the app id, so the literal changed to slideprepper:slide_deck_generation (on Fu's green light). |
kyteinsky
approved these changes
Nov 11, 2026
Comment on lines
+25
to
+26
| DECK_OUTPUT_LABELS = ("PowerPoint (pptx)", "HTML", "PDF") | ||
| DECK_FALLBACK_LABEL = "Slide deck" |
Contributor
There was a problem hiding this comment.
nit: maybe these and deck_reply could be named like slideprepper_reply to diambiguated between this and the deck app/tools (kanban board)
…lots
The merged deck tool schedules the slideprepper task with a "prompt" key
the task type does not register, so every deck call from chat fails at
schedule time ("Missing key: input"), and it reads a "slide_deck" output
the task never sends: the task answers one file id per selected output
format under "slide_decks". The dispatch now speaks the registered
contract and the reply relays one labeled download link per generated
file, behind an instruction line that keeps a compressing relay from
dropping links. The task-type literal follows the app's id rename.
Assisted-by: opencode (zai/glm-5.3)
Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
…p ambiguity The doc_gen tool sits next to the Deck (kanban) tools, so deck_reply and the DECK_* constants read as if they belonged to those. The slideprepper prefix names the task they actually serve. Assisted-by: opencode (zai/glm-5.3) Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
WSHAPER
force-pushed
the
fix/deck-tool-task-contract
branch
from
November 16, 2026 10:36
eb386e7 to
2abf89f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311
The slides branch of generate_document now speaks the deck task's registered contract: input as the payload key, slide_decks as the output key, and one labeled download link per generated file in the reply.
The task type literal follows the ExApp's id (marp_slides is now slideprepper).
Assisted-by: opencode (zai/glm-5.3)