Skip to content

fix(tools): dispatch the deck task with its registered slots - #313

Open
WSHAPER wants to merge 2 commits into
mainfrom
fix/deck-tool-task-contract
Open

WSHAPER wants to merge 2 commits into
mainfrom
fix/deck-tool-task-contract

Conversation

@WSHAPER

@WSHAPER WSHAPER commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #311

The slides branch of generate_document now speaks the deck task's registered contract: input as the payload key, slide_decks as the output key, and one labeled download link per generated file in the reply.

The task type literal follows the ExApp's id (marp_slides is now slideprepper).

Assisted-by: opencode (zai/glm-5.3)

@WSHAPER

WSHAPER commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Heads-up on one detail in this diff: the deck ExApp is being renamed from marp_slides to SlidePrepper, and the task type id follows the app id, so the literal changed to slideprepper:slide_deck_generation (on Fu's green light).

Comment thread ex_app/lib/all_tools/doc_gen.py Outdated
Comment on lines +25 to +26
DECK_OUTPUT_LABELS = ("PowerPoint (pptx)", "HTML", "PDF")
DECK_FALLBACK_LABEL = "Slide deck"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe these and deck_reply could be named like slideprepper_reply to diambiguated between this and the deck app/tools (kanban board)

@WSHAPER WSHAPER Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid nit, thanks, resolved in eb386e7.

…lots

The merged deck tool schedules the slideprepper task with a "prompt" key
the task type does not register, so every deck call from chat fails at
schedule time ("Missing key: input"), and it reads a "slide_deck" output
the task never sends: the task answers one file id per selected output
format under "slide_decks". The dispatch now speaks the registered
contract and the reply relays one labeled download link per generated
file, behind an instruction line that keeps a compressing relay from
dropping links. The task-type literal follows the app's id rename.

Assisted-by: opencode (zai/glm-5.3)
Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
…p ambiguity

The doc_gen tool sits next to the Deck (kanban) tools, so deck_reply and
the DECK_* constants read as if they belonged to those. The slideprepper
prefix names the task they actually serve.

Assisted-by: opencode (zai/glm-5.3)
Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
@WSHAPER
WSHAPER force-pushed the fix/deck-tool-task-contract branch from eb386e7 to 2abf89f Compare November 16, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deck generation from chat always fails: Missing key input

2 participants