Repository navigation
Conversation
Offer an app-managed certificate for existing HTTPS accounts while retaining system KeyChain fallback. Guard against absent accounts and clear the password entry after import. Assisted-by: ChatGPT:GPT-6
morhaviv
force-pushed
the
feature/manual-pkcs12-client-certificate
branch
from
November 15, 2026 19:41
0a5fe65 to
d01e7ab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ChatGPT:GPT-6
When using mTLS, Android makes the user have to re-select the client certificate being used every ~24 hours. Its frustrating and makes the auto-upload feature stop working, forcing you to force close the app every day and reopen it, just to make it keep the auto-upload enabled.
There have been multiple issues opened by different users here in the repo the complained about it as well.
#16762
#12931
This feature (along with another PR I'm opening to the android-library) lets you choose a custom certificate manually, and makes the http client manually use this certificate - instead of relaying on the OS's feature. (nextcloud/android-library#2213)
I've been using this version of the app for the past 48 hours and it has been working just as expected, and I couldn't find anything it broke.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)
It was generated using AI, but I went over it and it looks fine,