Skip to content

feat(settings): add optional app-managed PKCS#12 client certificate UI - #18055

Open
morhaviv wants to merge 1 commit into
nextcloud:masterfrom
morhaviv:feature/manual-pkcs12-client-certificate
Open

morhaviv wants to merge 1 commit into
nextcloud:masterfrom
morhaviv:feature/manual-pkcs12-client-certificate

Conversation

@morhaviv

@morhaviv morhaviv commented Nov 15, 2026 •

Copy link
Copy Markdown

Assisted-by: ChatGPT:GPT-6

When using mTLS, Android makes the user have to re-select the client certificate being used every ~24 hours. Its frustrating and makes the auto-upload feature stop working, forcing you to force close the app every day and reopen it, just to make it keep the auto-upload enabled.

There have been multiple issues opened by different users here in the repo the complained about it as well.

#16762
#12931

This feature (along with another PR I'm opening to the android-library) lets you choose a custom certificate manually, and makes the http client manually use this certificate - instead of relaying on the OS's feature. (nextcloud/android-library#2213)

I've been using this version of the app for the past 48 hours and it has been working just as expected, and I couldn't find anything it broke.

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

It was generated using AI, but I went over it and it looks fine,

  • [ V ] The content of this PR was partly or fully generated using AI (N/A)

Offer an app-managed certificate for existing HTTPS accounts while
retaining system KeyChain fallback. Guard against absent accounts and
clear the password entry after import.

Assisted-by: ChatGPT:GPT-6

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant