Skip to content

fix: drop the typing-extensions floor that existed only for wheels - #252

Merged
lesnik512 merged 1 commit into
mainfrom
deps/drop-wheel-floors
Oct 24, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
deps/drop-wheel-floors

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Summary

typing-extensions>=4.12.2 was declared only so the old CI6 floors job, which pinned every direct dependency to its floor on every Python, would not drag pydantic back to a build with no cp313 wheel. The package never imports typing_extensions, and CI10 (modern-python/.github#142) resolves the whole tree at the lowest versions with a wheel on every entry above the floor Python, so the resolver picks a typing-extensions that pydantic accepts by itself. With no requirement left behind it, the line goes.

Checklist

  • floors passes locally on 3.11, 3.12, 3.13 and 3.14, on the committed change, same steps as _checks.yml

@github-actions

Copy link
Copy Markdown

Benchmark gate

✅ gate passed

scenario msg/s delete/msg WALrec/msg WALB/msg fpi upd del dead_tup
consumer/w1/b10 1335 1.000 6.71 921 242 5000 5000 10000
consumer/w1/b100 1428 1.000 7.11 1154 243 5000 5000 10000
consumer/w2/b10 1600 1.000 6.72 923 242 5000 5000 10000
consumer/w2/b100 1853 1.000 7.11 1154 243 5000 5000 10000
consumer/w4/b10 1652 1.000 6.74 951 242 5000 5000 10000
consumer/w4/b100 1912 1.000 7.11 1153 243 5000 5000 10000
consumer/w1/b100/tfbs100 5495 0.010 6.17 1172 265 5000 5000 10000
consumer/w1/b100/interval1-10 1429 1.000 7.11 1156 244 5000 5000 10000
producer/w1/b100 3020 0.000 3.04 597 1 0 0 0
producer/w1/b100/ppt1 956 0.000 4.04 635 0 0 0 0

Gated (fails the build): delete_calls + tuple counters (upd/del/ins) + the producer's insert_calls, exact; select_calls and other_calls within +2; wal_records within a 10% band; fetch_calls within 2x. msg/s, WAL bytes and total calls are informational (timing/FPI noise).

@lesnik512
lesnik512 merged commit 94d750b into main Oct 24, 2026
15 checks passed
@lesnik512
lesnik512 deleted the deps/drop-wheel-floors branch October 24, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant