Repository navigation
fix: drop the typing-extensions floor that existed only for wheels - #252
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing-extensions>=4.12.2was declared only so the old CI6floorsjob, which pinned every direct dependency to its floor on every Python, would not drag pydantic back to a build with no cp313 wheel. The package never importstyping_extensions, and CI10 (modern-python/.github#142) resolves the whole tree at the lowest versions with a wheel on every entry above the floor Python, so the resolver picks atyping-extensionsthat pydantic accepts by itself. With no requirement left behind it, the line goes.Checklist
floorspasses locally on 3.11, 3.12, 3.13 and 3.14, on the committed change, same steps as_checks.yml