Skip to content

Avoid repeated array merges in prompt formatting #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chr-hertel merged 1 commit into from
Nov 2, 2026
Merged

Avoid repeated array merges in prompt formatting #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Capability/Formatter/PromptResultFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ public function format(mixed $promptGenerationResult): array
if ($item instanceof PromptMessage) {
$result[] = $item;
} else {
$result = array_merge($result, $this->format($item));
foreach ($this->format($item) as $key => $message) {
if (\is_int($key)) {
$result[] = $message;
} else {
$result[$key] = $message;
}
}
}
}

Expand Down
19 changes: 19 additions & 0 deletions tests/Unit/Capability/Formatter/PromptResultFormatterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,25 @@

class PromptResultFormatterTest extends TestCase
{
public function testMixedMessagesPreserveNestedKeysAndOrder(): void
{
$first = new PromptMessage(Role::User, new TextContent('first'));
$second = new PromptMessage(Role::Assistant, new TextContent('second'));
$third = new PromptMessage(Role::User, new TextContent('third'));

$result = (new PromptResultFormatter())->format([
$first,
['named' => $second, 8 => $first],
['named' => $third, 5 => $second],
]);

$this->assertSame([0, 'named', 1, 2], array_keys($result));
$this->assertSame($first, $result[0]);
$this->assertSame($third, $result['named']);
$this->assertSame($first, $result[1]);
$this->assertSame($second, $result[2]);
}

public function testFormatPromptMessage(): void
{
$message = new PromptMessage(Role::User, new TextContent('hello'));
Expand Down
Loading