Skip to content

Make gather an optional component - #9755

Merged
Jim Griesmer (greazer) merged 78 commits into
masterfrom
dev/jim/use-new-gather
Mar 8, 2020
Merged

Jim Griesmer (greazer) merged 78 commits into
masterfrom
dev/jim/use-new-gather

Conversation

@greazer

@greazer Jim Griesmer (greazer) commented Jan 24, 2020 •

Copy link
Copy Markdown

This PR does two things. First, it modifies the building of gather functionality to make use of a non OSS component. Second, it adjusts the existing CellHash management to be per-notebook rather than a singleton. Both of the above were related, so it made sense to do it in one PR.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements. Coming in subsequent PR.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Jim Griesmer added 30 commits November 8, 2019 17:13
cell executionId for gather.
Dynamically look for python-program-analysis. If not there
gather is unsupported.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Comment thread .prettierrc.js Resolved

@DonJayamanne Don Jayamanne (DonJayamanne) left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rich Chiodo (@rchiodo) Jim Griesmer (@greazer)
I don't know much about gather now how it works/what it does.

Looking at the code, the gather needs to be tied to a specific notebook, and we do this by using some hops by using IInteractiveWindowListener, then going through all listeners and finding the specific item and casting to a type, then getting something out of that (service property, etc). This seems quite complicated to me.

Shouldn't we have a better way to tie these instances to a specific notebook.
I.e. either each class maintains its own collection of objects against notebooks (its own map/dict). Then ensure we pass the notebook uri (Interactive Window/Native Editor) objects to some of these interfaces, such as ICellHashListener and ICellHashProvider.

Comment thread src/client/datascience/types.ts Resolved
Comment thread src/client/datascience/types.ts Resolved
Comment thread src/client/datascience/gather/gather.ts Resolved
Comment thread src/client/datascience/types.ts Resolved

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@sonarqubecloud

sonarqubecloud Bot commented Mar 8, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@greazer
Jim Griesmer (greazer) merged commit d1b2204 into master Mar 8, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 17, 2020
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the dev/jim/use-new-gather branch June 19, 2020 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants