Skip to content

Update Test Explorer icons to match new VS Code icons - #8360

Merged
Karthik Nadig (karthiknadig) merged 5 commits into
microsoft:masterfrom
luabud:newicons
Nov 5, 2019
Merged

Karthik Nadig (karthiknadig) merged 5 commits into
microsoft:masterfrom
luabud:newicons

Conversation

@luabud

@luabud Luciana Abud (luabud) commented Nov 4, 2019 •

Copy link
Copy Markdown
Member

For #7809

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@luabud Luciana Abud (luabud) added the no-changelog No news entry required label Nov 4, 2019
Comment thread resources/dark/debug.svg
<path d="M512 288v-32h-96.645c-2.931-36.343-15.893-69.513-35.835-96.125h80.972l35.030-140.12-31.045-7.761-28.97 115.88h-87.34c-0.446-0.347-0.898-0.687-1.349-1.028 3.355-9.751 5.181-20.211 5.181-31.097 0.001-52.88-42.979-95.749-95.999-95.749s-96 42.869-96 95.75c0 10.886 1.825 21.346 5.181 31.097-0.45 0.342-0.902 0.681-1.349 1.028h-87.34l-28.97-115.88-31.045 7.761 35.030 140.12h80.972c-19.942 26.611-32.903 59.781-35.834 96.124h-96.645v32h96.685c1.901 22.832 7.754 44.406 16.819 63.875h-61.996l-35.030 140.119 31.045 7.762 28.97-115.881h56.177c29.346 39.016 73.698 63.875 123.33 63.875s93.983-24.859 123.331-63.875h56.177l28.97 115.881 31.045-7.762-35.030-140.119h-61.996c9.065-19.469 14.918-41.043 16.818-63.875h96.685z"></path>
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M10.8775 4.5V3.91833C10.8775 2.30658 9.57092 1 7.95917 1C6.34742 1 5.04084 2.30658 5.04084 3.91833V4.5H4.20835L2.54527 2.8285L1.95216 3.41862L3.56303 5.03764L3.54447 5.08683C3.22212 5.94055 3.04084 6.90159 3.04084 7.91833C3.04084 8.11403 3.04755 8.30766 3.0607 8.49886L3.0637 8.5425H1V9.37916H3.16882L3.17494 9.41265C3.34718 10.3545 3.6785 11.2152 4.12918 11.9442L4.16317 11.9992L2.19995 13.9624L2.79157 14.554L4.66326 12.6823L4.72075 12.748C5.58881 13.7401 6.72251 14.3367 7.95917 14.3367C9.17697 14.3367 10.2949 13.7582 11.1576 12.7932L11.2153 12.7287L13.1251 14.6481L13.7182 14.058L11.7218 12.0515L11.7565 11.9964C12.2239 11.2564 12.567 10.3771 12.7434 9.41265L12.7495 9.37916H14.92V8.5425H12.8546L12.8576 8.49886C12.8708 8.30766 12.8775 8.11403 12.8775 7.91833C12.8775 6.88815 12.6914 5.91515 12.361 5.05303L12.3421 5.00354L13.9119 3.43371L13.3203 2.8421L11.6624 4.5H10.8775ZM5.87751 4.5V3.91833C5.87751 2.76866 6.8095 1.83667 7.95917 1.83667C9.10884 1.83667 10.0408 2.76866 10.0408 3.91833V4.5H5.87751ZM11.5739 5.33667L11.5938 5.38957C11.8772 6.14269 12.0408 7.00011 12.0408 7.91833C12.0408 9.52826 11.5379 10.9522 10.7668 11.9546C9.99644 12.9561 8.99584 13.5 7.95917 13.5C6.9225 13.5 5.9219 12.9561 5.15153 11.9546C4.38048 10.9522 3.8775 9.52826 3.8775 7.91833C3.8775 7.00011 4.0411 6.1427 4.32451 5.38957L4.34441 5.33667H11.5739Z" fill="#C5C5C5"/>
</svg>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match the VSCode debug icon (Does not have the x in the middle). Is that ok?
image

Same with light version.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😊 it's to replace the one in the test explorer:

image

@codecov-io

Codecov (codecov-io) commented Nov 4, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8360 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8360      +/-   ##
==========================================
+ Coverage   59.23%   59.35%   +0.11%     
==========================================
  Files         508      509       +1     
  Lines       23236    23285      +49     
  Branches     3750     3762      +12     
==========================================
+ Hits        13765    13820      +55     
+ Misses       8577     8566      -11     
- Partials      894      899       +5
Impacted Files Coverage Δ
src/client/datascience/cellFactory.ts 70.51% <0%> (-19.15%) ⬇️
src/client/datascience/gather/gather.ts 63.04% <0%> (-2.42%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 22.22% <0%> (-1.7%) ⬇️
...ascience/interactive-ipynb/nativeEditorProvider.ts 53.65% <0%> (-0.89%) ⬇️
src/client/terminals/codeExecution/helper.ts 21.27% <0%> (-0.73%) ⬇️
src/client/testing/navigation/symbolProvider.ts 93.1% <0%> (-0.65%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 14.92% <0%> (-0.23%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 24.21% <0%> (-0.13%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 6.02% <0%> (-0.02%) ⬇️
src/client/datascience/constants.ts 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b19d0...2741acc. Read the comment docs.

@luabud Luciana Abud (luabud) removed the no-changelog No news entry required label Nov 5, 2019
@luabud
Luciana Abud (luabud) marked this pull request as ready for review November 5, 2019 04:06
@karthiknadig
Karthik Nadig (karthiknadig) merged commit a139d63 into microsoft:master Nov 5, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 12, 2019
@luabud
Luciana Abud (luabud) deleted the newicons branch December 6, 2019 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants