Repository navigation
Refactor classes in prep for perf improvements - #8319
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoNov 1, 2019
Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
Don Jayamanne (DonJayamanne) merged 2 commits into
Conversation
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
October 31, 2019 18:38
Codecov Report
@@ Coverage Diff @@
## master #8319 +/- ##
=========================================
- Coverage 59.33% 59.04% -0.3%
=========================================
Files 504 506 +2
Lines 23096 23133 +37
Branches 3737 3733 -4
=========================================
- Hits 13704 13658 -46
- Misses 8500 8583 +83
Partials 892 892
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7242
Starting notebooks and dealing with kernels is slow. Also, there'll be lot of work related to kernels in the near future.
Hence, splitting the two concerns into two separate classes.
This PR only focuses on the refactor (to make code reviews easy). I.e. no changes to logic/functionality in this PR
Later PRs will focus on refactoring the existing code to improve performance.