Skip to content

Refactor classes in prep for perf improvements - #8319

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:dsPerfImprovements2
Nov 1, 2019
Merged

Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:dsPerfImprovements2

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Oct 31, 2019 •

Copy link
Copy Markdown

Part of #7242
Starting notebooks and dealing with kernels is slow. Also, there'll be lot of work related to kernels in the near future.
Hence, splitting the two concerns into two separate classes.

This PR only focuses on the refactor (to make code reviews easy). I.e. no changes to logic/functionality in this PR

Later PRs will focus on refactoring the existing code to improve performance.

@codecov-io

Codecov (codecov-io) commented Oct 31, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8319 into master will decrease coverage by 0.29%.
The diff coverage is 57.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8319     +/-   ##
=========================================
- Coverage   59.33%   59.04%   -0.3%     
=========================================
  Files         504      506      +2     
  Lines       23096    23133     +37     
  Branches     3737     3733      -4     
=========================================
- Hits        13704    13658     -46     
- Misses       8500     8583     +83     
  Partials      892      892
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernelService.ts 54.67% <54.67%> (ø)
src/client/datascience/jupyter/notebookStarter.ts 59.34% <59.34%> (ø)
src/client/datascience/jupyter/jupyterExecution.ts 51.03% <87.5%> (-1.34%) ⬇️
src/client/testing/serviceRegistry.ts 48.64% <0%> (-46.85%) ⬇️
src/client/testing/codeLenses/main.ts 44.44% <0%> (-33.34%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 66.66% <0%> (-33.34%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 75% <0%> (-25%) ⬇️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 60% <0%> (-20%) ⬇️
src/client/common/utils/icons.ts 83.33% <0%> (-16.67%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9c62c...757d4c8. Read the comment docs.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 072ccea into microsoft:master Nov 1, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 8, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the dsPerfImprovements2 branch November 15, 2019 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants