Repository navigation
Make sure when typing in an edit box, the notebook editor scrolls - #8252
Merged
Merged
Conversation
Rich Chiodo (rchiodo)
requested review from
David Kutugata (DavidKutu),
Don Jayamanne (DonJayamanne) and
Ian Huff (IanMatthewHuff)
October 28, 2019 16:59
Codecov Report
@@ Coverage Diff @@
## master #8252 +/- ##
==========================================
+ Coverage 59.01% 59.02% +<.01%
==========================================
Files 504 504
Lines 23089 23093 +4
Branches 3733 3733
==========================================
+ Hits 13626 13630 +4
Misses 8583 8583
Partials 880 880
Continue to review full report at Codecov.
|
Don Jayamanne (DonJayamanne)
approved these changes
Oct 28, 2019
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Only one question related to the argument focusCode in the focusCell function.
Approving as its just a question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8205
Whenever we type, make sure the text is visible.
This does not address all scrolling issues though. That's this bug here: #7270