Skip to content

Make sure when typing in an edit box, the notebook editor scrolls - #8252

Merged
Rich Chiodo (rchiodo) merged 5 commits into
masterfrom
rchiodo/scroll_to_focus
Oct 28, 2019
Merged

Rich Chiodo (rchiodo) merged 5 commits into
masterfrom
rchiodo/scroll_to_focus

Conversation

@rchiodo

Copy link
Copy Markdown

For #8205

Whenever we type, make sure the text is visible.

This does not address all scrolling issues though. That's this bug here: #7270

@codecov-io

Codecov (codecov-io) commented Oct 28, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8252 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8252      +/-   ##
==========================================
+ Coverage   59.01%   59.02%   +<.01%     
==========================================
  Files         504      504              
  Lines       23089    23093       +4     
  Branches     3733     3733              
==========================================
+ Hits        13626    13630       +4     
  Misses       8583     8583              
  Partials      880      880
Impacted Files Coverage Δ
src/datascience-ui/interactive-common/mainState.ts 50.94% <100%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3fa81...fc2b456. Read the comment docs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question related to the argument focusCode in the focusCell function.
Approving as its just a question.

@rchiodo
Rich Chiodo (rchiodo) merged commit 6046f83 into master Oct 28, 2019
@rchiodo
Rich Chiodo (rchiodo) deleted the rchiodo/scroll_to_focus branch October 28, 2019 19:45
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants