Skip to content

Make Jupyter Server name clickable to select Jupyter server - #13657

Merged
Shantnu Suman (shsuman) merged 1 commit into
microsoft:masterfrom
shsuman:shsuman/serverName_clickable
Aug 28, 2020
Merged

Shantnu Suman (shsuman) merged 1 commit into
microsoft:masterfrom
shsuman:shsuman/serverName_clickable

Conversation

@shsuman

@shsuman Shantnu Suman (shsuman) commented Aug 28, 2020 •

Copy link
Copy Markdown
Member

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

The Jupyter server name on the top right corner of a notebook/Interactive window is now clickable and it basically executes the command "Python: Specify local or remote Jupyter server for connection" and lets you change the way you want to connect to a Jupyter server directly from the UI

image

@codecov-commenter

ghost commented Aug 28, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #13657 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13657      +/-   ##
==========================================
- Coverage   59.72%   59.69%   -0.03%     
==========================================
  Files         673      673              
  Lines       37659    37659              
  Branches     5403     5403              
==========================================
- Hits        22490    22482       -8     
- Misses      14002    14007       +5     
- Partials     1167     1170       +3     
Impacted Files Coverage Δ
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e00525...e680608. Read the comment docs.

@shsuman
Shantnu Suman (shsuman) force-pushed the shsuman/serverName_clickable branch from 00fb730 to e680608 Compare August 28, 2020 18:56
@sonarqubecloud

ghost commented Aug 28, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants