Skip to content

Excessive logging results in log containing with 1000s of lines unwanted entries #22993

Closed

Description

The following log entry exists in Python extension when ever Jupyter extension attempts to access some API
This is logged over 1500 times
I guess everytime the Jupyter exension attempts to access the known property its logged.
I'd consider removing this from the logs to reduce the size of the logs (as i was unable to upload the logs in a github issue)

2024-02-29 00:14:55.158 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.167 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.178 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.187 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.188 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.189 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.190 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.192 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.193 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.194 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.196 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.197 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.198 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.199 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.201 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.203 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.222 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.227 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.235 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.237 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.238 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.240 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.271 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.274 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.276 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.279 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.283 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined
2024-02-29 00:14:55.286 [debug] Extension ms-toolsai.jupyter accessed known with args: undefined

Activity

  1. karrtikr commented on Feb 29, 2024

    @karrtikr

    Based on discussion with team, this indicates to us a problem that known is being called so many times, which is against the guidelines: #22994 (comment). So unless it has a performance impact (yet to investigate), we might just keep it.

  2. DonJayamanne commented on Mar 3, 2024

    @DonJayamanne
    Author

    So unless it has a performance impact (yet to investigate), we might just keep it.

    I think you missed this i was unable to upload the logs in a github issue

    I.e. as a user I might not be able to paste the logs directly into a github issue, I have to now save the logs to a file and then upload the file.

    E.g. when I save the logs,
    one is 1.1MB and other is 250KB.

    Anyways, just though of highlighting this.

  3. karrtikr commented on Mar 4, 2024

    @karrtikr

    I've actually removed the logging, seems like the pre-release wasn't published #23021 (comment).

    this indicates to us a problem that known is being called so many times

    This is no longer a problem, as known just returns from cache now, so this issue can be considered as done.

  4. locked as resolved and limited conversation to collaborators on Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

triage-neededNeeds assignment to the proper sub-team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions