This repository was archived by the owner on May 20, 2025. It is now read-only.
Repository navigation
[docs][ios] readme: improved “Multi-Deployment Testing” chapter for iOS - #690
Merged
Sergey Akhalkov (sergey-akhalkov) merged 1 commit intoFeb 9, 2017
Merged
Conversation
|
Hi Sergey Akhalkov (@sergey-akhalkov), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Sergey Akhalkov (sergey-akhalkov)
changed the title
Richard Hua (richardhuaaa)
approved these changes
Feb 8, 2017
Richard Hua (richardhuaaa)
left a comment
Richard Hua (richardhuaaa)
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just left a small comment, feel free to merge it after.
Contributor
There was a problem hiding this comment.
Could you leave a short note here explaining why? (Similar to your PR description, with a link)
After RN 0.40 it is not possible to use other configurations than Debug and Release (react/react-native#11813) As workaround we could make Staging’s Build Products Path value the same as for Release configuration. Fix #688
Contributor
Author
|
Fixed it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After RN 0.40 it is not possible to use other configurations than Debug and Release react/react-native#11813
As workaround we could make Staging’s Build Products Path value the same as for Release configuration.
Fix #688