Skip to content

ci: pin cargo-llvm-cov installer to release SHA - #583

Merged
Stella Huang (StellaHuang95) merged 1 commit into
mainfrom
stellahuang95-repository-sync
Nov 17, 2026
Merged

Stella Huang (StellaHuang95) merged 1 commit into
mainfrom
stellahuang95-repository-sync

Conversation

@StellaHuang95

@StellaHuang95 Stella Huang (StellaHuang95) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Pin the remaining mutable taiki-e/install-action@cargo-llvm-cov reference in all three coverage workflows (coverage.yml, coverage-baseline.yml, and coverage-macos.yml) to ab49d3c64680143e184118bed66a46419fc15519, the commit for v2.90.5. Add an explicit tool: cargo-llvm-cov input and a human-readable version comment.

Use the versioned release rather than the generated tool-tag commit: the action maintainer discourages pinning tool tags by hash because those generated commits become unreferenced after subsequent releases. The selected release commit is the parent of the tool-tag commit verified during the original investigation, and their only difference is the tool input default; specifying that input explicitly preserves the existing installation behavior.

All action references in the repository's workflows use full-length commit SHAs. Existing weekly grouped Dependabot updates and the seven-day cooldown are unchanged.

Use the v2.90.5 release commit with an explicit cargo-llvm-cov tool input in all three coverage workflows.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Performance Report (Linux)

Result: ✅ Within regression budgets

Metric PR Baseline Delta Change Blocking budget Status
Server startup P50 1ms 1ms +0ms +0.0% >5ms and >100% ➖
Server startup P95 1ms 1ms +0ms +0.0% >50ms and >200% ➖
Discovery duration P50 52ms 51ms +1ms +2.0% >25ms and >30% 🔺
Discovery duration P95 55ms 54ms +1ms +1.9% >50ms and >50% 🔺
Startup-to-first environment P50 10ms 10ms +0ms +0.0% >20ms and >100% ➖
Startup-to-first environment P95 13ms 12ms +1ms +8.3% >25ms and >100% 🔺
Cold discovery duration P50 114ms 116ms -2ms -1.7% >100ms and >50% ✅
Refresh round-trip P50 52ms 51ms +1ms +2.0% >25ms and >30% 🔺
Refresh round-trip P95 55ms 54ms +1ms +1.9% >50ms and >50% 🔺
Request-to-first environment P50 9ms 9ms +0ms +0.0% >20ms and >100% ➖
Request-to-first environment P95 12ms 11ms +1ms +9.1% >25ms and >100% 🔺
Cold refresh round-trip P50 114ms 116ms -2ms -1.7% >100ms and >50% ✅
Workload PR Baseline
Environments 5 5
Managers 1 1

A regression must exceed both the documented absolute and relative budget. Environment and manager inventories must match exactly within the same inventory schema.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Test Coverage Report (Linux)

Result: ✅ Within regression budget

Metric PR Baseline Delta
Lines 85.506% 85.506% +0.000pp
Functions 88.038% 88.038% +0.000pp

Allowed numerical tolerance: 0.01 percentage points.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Performance Report (Windows)

Result: ✅ Within regression budgets

Metric PR Baseline Delta Change Blocking budget Status
Server startup P50 7ms 7ms +0ms +0.0% >10ms and >50% ➖
Server startup P95 10ms 10ms +0ms +0.0% >50ms and >100% ➖
Discovery duration P50 100ms 101ms -1ms -1.0% >150ms and >50% ✅
Discovery duration P95 109ms 104ms +5ms +4.8% >250ms and >100% 🔺
Startup-to-first environment P50 17ms 17ms +0ms +0.0% >25ms and >50% ➖
Startup-to-first environment P95 18ms 23ms -5ms -21.7% >100ms and >100% ✅
Cold discovery duration P50 102ms 100ms +2ms +2.0% >150ms and >50% 🔺
Refresh round-trip P50 101ms 101ms +0ms +0.0% >150ms and >50% ➖
Refresh round-trip P95 109ms 105ms +4ms +3.8% >250ms and >100% 🔺
Request-to-first environment P50 9ms 9ms +0ms +0.0% >25ms and >50% ➖
Request-to-first environment P95 11ms 15ms -4ms -26.7% >100ms and >100% ✅
Cold refresh round-trip P50 103ms 100ms +3ms +3.0% >150ms and >50% 🔺
Workload PR Baseline
Environments 8 8
Managers 1 1

A regression must exceed both the documented absolute and relative budget. Environment and manager inventories must match exactly within the same inventory schema.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Performance Report (macOS ARM64)

Result: ✅ Within regression budgets

Metric PR Baseline Delta Change Blocking budget Status
Server startup P50 54ms 61ms -7ms -11.5% >100ms and >50% ✅
Server startup P95 61ms 116ms -55ms -47.4% >750ms and >100% ✅
Discovery duration P50 96ms 96ms +0ms +0.0% >100ms and >50% ➖
Discovery duration P95 139ms 131ms +8ms +6.1% >300ms and >100% 🔺
Startup-to-first environment P50 77ms 68ms +9ms +13.2% >150ms and >50% 🔺
Startup-to-first environment P95 116ms 93ms +23ms +24.7% >250ms and >100% 🔺
Cold discovery duration P50 132ms 148ms -16ms -10.8% >250ms and >50% ✅
Refresh round-trip P50 97ms 97ms +0ms +0.0% >250ms and >50% ➖
Refresh round-trip P95 140ms 131ms +9ms +6.9% >300ms and >100% 🔺
Request-to-first environment P50 28ms 27ms +1ms +3.7% >50ms and >50% 🔺
Request-to-first environment P95 33ms 39ms -6ms -15.4% >100ms and >100% ✅
Cold refresh round-trip P50 133ms 148ms -15ms -10.1% >600ms and >50% ✅
Workload PR Baseline
Environments 11 11
Managers 1 1

A regression must exceed both the documented absolute and relative budget. Environment and manager inventories must match exactly within the same inventory schema.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Test Coverage Report (Windows)

Result: ✅ Within regression budget

Metric PR Baseline Delta
Lines 83.028% 83.028% +0.000pp
Functions 85.379% 85.379% +0.000pp

Allowed numerical tolerance: 0.01 percentage points.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Performance Report (macOS)

Result: ✅ Within regression budgets

Metric PR Baseline Delta Change Blocking budget Status
Server startup P50 63ms 62ms +1ms +1.6% >100ms and >50% 🔺
Server startup P95 78ms 105ms -27ms -25.7% >750ms and >100% ✅
Discovery duration P50 112ms 115ms -3ms -2.6% >100ms and >50% ✅
Discovery duration P95 140ms 134ms +6ms +4.5% >300ms and >100% 🔺
Startup-to-first environment P50 110ms 107ms +3ms +2.8% >150ms and >50% 🔺
Startup-to-first environment P95 128ms 149ms -21ms -14.1% >250ms and >100% ✅
Cold discovery duration P50 163ms 171ms -8ms -4.7% >250ms and >50% ✅
Refresh round-trip P50 113ms 115ms -2ms -1.7% >250ms and >50% ✅
Refresh round-trip P95 141ms 134ms +7ms +5.2% >300ms and >100% 🔺
Request-to-first environment P50 45ms 49ms -4ms -8.2% >50ms and >50% ✅
Request-to-first environment P95 58ms 66ms -8ms -12.1% >100ms and >100% ✅
Cold refresh round-trip P50 164ms 171ms -7ms -4.1% >600ms and >50% ✅
Workload PR Baseline
Environments 10 10
Managers 1 1

A regression must exceed both the documented absolute and relative budget. Environment and manager inventories must match exactly within the same inventory schema.

@rchiodo

Copy link
Copy Markdown

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown

Reviewed commit: e04625bcbb099cbbdd7bb3b6d21494b2f752a2ff

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "3801b3f5535d24047c24f35d39827e1ac4ec5222e9a23c266bae0cc9714bf105": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 17, 2026
@StellaHuang95
Stella Huang (StellaHuang95) merged commit f73d8b7 into main Nov 17, 2026
82 checks passed
@StellaHuang95
Stella Huang (StellaHuang95) deleted the stellahuang95-repository-sync branch November 17, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants