Skip to content

chore: port the leaf classes of the client from the Node.js client - #2059

Open
Yury Semikhatsky (yury-s) wants to merge 22 commits into
microsoft:mainfrom
yury-s:rewrite-leaves
Open

Yury Semikhatsky (yury-s) wants to merge 22 commits into
microsoft:mainfrom
yury-s:rewrite-leaves

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • The leaf classes now follow their upstream files member by member, each with a // Port of <file>.ts. header and // java: notes where Java differs: artifact, stream, writableStream, download, video, screencast, consoleMessage, dialog, fileChooser, webError, input, worker, cdpSession, debugger, clock, webStorage, credentials, webmcp, selectors, localUtils, jsonPipe.
  • addSourceUrlToScript and mkdirIfNeeded move out of Utils into new ClientHelper and FileUtils, as in clientHelper.ts and fileUtils.ts.
  • No behaviour change: mostly reordering and renaming, the protocol messages and error strings are the same.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant