Repository navigation
Fix -Wsign-compare warning when reading hpage_pmd_size - #1447
Merged
Merged
Conversation
unix_detect_large_page_size compares the parsed 'long size' against SIZE_MAX, which is unsigned, so builds with -Wsign-compare (or -Wextra) warn about comparing integers of different signedness. size is known to be positive at that point, so cast it to unsigned long for the comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unix_detect_large_page_size compares the parsed 'long size' against SIZE_MAX, which is unsigned, so builds with -Wsign-compare (or -Wextra) warn about comparing integers of different signedness. size is known to be positive at that point, so cast it to unsigned long for the comparison.