You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
urllib has a requirement of ^2.2.2 and I was wondering if we could adjust it to something that works with the following package constrain urllib3>=1.26.5,<2
for httpx, it seems the http2 extras are not referenced directly, so maybe the references can be changed to httpx>=0.28.0 and provide an extra if you want to talk to http2 servers? Like this
The design choice here for http/2 is to add it systematically so clients "automatically" upgrade to http/2 when available without developers having to do anything. Is that causing an issue on your end? (besides heavier deployments)
As for urllib, I believe a range should work here (granted that the CI is happy with the change). It's probably on a fixed version because of dependabot updates to begin with. Are you getting version resolution conflicts?
@baywet maybe we can do this for version 1.8.0 as well?
Versions are cheap thanks to automation, I'd rather have that as another patch as it'll provide more stop gaps to consumers in case something is wrong.
According to the version history of urllib3 version 1.26.20 is actually newer then version 2.2.2 which is a current requirement.
Because there were some issues with version 2.0.* and 2.1.* other big projects (home assistant, one of the most popular project on github completely built in python) blocked urllib3 with <2.
I would suggest to set the urllib3 dependency to urllib3 = ">=1.26.17,!2.0.*,!2.1.*" this will allow more people to utilize kiota, while still skipping the faulty versions and not blocking people from using >2.1 if they want
+1 on this one really. I can't tell what the purpose of the poolmanager here as it isn't referenced anywhere else. Removing it and dropping the dependency would be the best here
(for others reading this svrooij shared with me that he is traveling for work/conferences at the moment, so this is likely to go to next week or maybe the following week, I'll remove the bot automation tags to reduce the noise here)
Activity
svrooij commentedon Jan 17, 2025
Vincent Biret (@baywet) maybe we can do this for version 1.8.0 as well?
baywet commentedon Jan 17, 2025
Hi Stephan van Rooij (@svrooij)
Thank you for using kiota and for reaching out.
Somehow I missed the notification for this one.
The design choice here for http/2 is to add it systematically so clients "automatically" upgrade to http/2 when available without developers having to do anything. Is that causing an issue on your end? (besides heavier deployments)
As for urllib, I believe a range should work here (granted that the CI is happy with the change). It's probably on a fixed version because of dependabot updates to begin with. Are you getting version resolution conflicts?
Versions are cheap thanks to automation, I'd rather have that as another patch as it'll provide more stop gaps to consumers in case something is wrong.
[-]Lower requirement for urllib and httpx[/-][+]Lower requirement for urllib[/+]svrooij commentedon Jan 17, 2025
According to the version history of urllib3 version
1.26.20is actually newer then version2.2.2which is a current requirement.Because there were some issues with version
2.0.*and2.1.*other big projects (home assistant, one of the most popular project on github completely built in python) blocked urllib3 with<2.I would suggest to set the urllib3 dependency to
urllib3 = ">=1.26.17,!2.0.*,!2.1.*"this will allow more people to utilize kiota, while still skipping the faulty versions and not blocking people from using>2.1if they wantbaywet commentedon Jan 20, 2025
Thank you for the additional information.
I think there's a serious mixing issue here.
If you search for "urllib" you'll get about a dozen results, but this is misleading since the vast majority of them come from the BCL parse utils
Searching for urllib3 instead only returns two results: the toml entry and the place where we set up the minimum TLS version for the client.
This looks highly suspicious to me: using types from one HTTP client lib to setup properties on another lib. I think somebody got mixed up here.
My suggestion is to:
more context:
Andrew Omondi (@andrueastman) I'd like your input on this one please.
andrueastman commentedon Jan 22, 2025
+1 on this one really. I can't tell what the purpose of the poolmanager here as it isn't referenced anywhere else. Removing it and dropping the dependency would be the best here
Would you be willing to make the changes here Stephan van Rooij (@svrooij) ?
baywet commentedon Jan 23, 2025
(for others reading this svrooij shared with me that he is traveling for work/conferences at the moment, so this is likely to go to next week or maybe the following week, I'll remove the bot automation tags to reduce the noise here)