Skip to content

Lower requirement for urllib #452

Closed
Closed

Description

Are the dependency requirements set in stone? Or can we lower urllib and httpx to something that works with these package constrains?

httpx = {extras = ["http2"], version = ">=0.28"}
urllib3 = "^2.2.2"

urllib has a requirement of ^2.2.2 and I was wondering if we could adjust it to something that works with the following package constrain urllib3>=1.26.5,<2

for httpx, it seems the http2 extras are not referenced directly, so maybe the references can be changed to httpx>=0.28.0 and provide an extra if you want to talk to http2 servers? Like this

Reason is, I've built this library for the Volvo Connected Vehicle api svrooij/py_volvo_connected that I want to use it in Home Assistant which has this package contrains

Without lowering the requirement (and #448), I would not be able to use kiota for this project and would be forced to go look for something else.

Activity

  1. moved this to Needs Triage 🔍 in Kiotaon Jan 15, 2025
  2. svrooij commented on Jan 17, 2025

    @svrooij
    ContributorAuthor

    Vincent Biret (@baywet) maybe we can do this for version 1.8.0 as well?

  3. baywet commented on Jan 17, 2025

    @baywet
    Member

    Hi Stephan van Rooij (@svrooij)
    Thank you for using kiota and for reaching out.

    Somehow I missed the notification for this one.

    The design choice here for http/2 is to add it systematically so clients "automatically" upgrade to http/2 when available without developers having to do anything. Is that causing an issue on your end? (besides heavier deployments)

    As for urllib, I believe a range should work here (granted that the CI is happy with the change). It's probably on a fixed version because of dependabot updates to begin with. Are you getting version resolution conflicts?

    @baywet maybe we can do this for version 1.8.0 as well?

    Versions are cheap thanks to automation, I'd rather have that as another patch as it'll provide more stop gaps to consumers in case something is wrong.

  4. moved this from Needs Triage 🔍 to Waits for author 🔁 in Kiotaon Jan 17, 2025
  5. changed the title [-]Lower requirement for urllib and httpx[/-] [+]Lower requirement for urllib[/+] on Jan 17, 2025
  6. svrooij commented on Jan 17, 2025

    @svrooij
    ContributorAuthor

    According to the version history of urllib3 version 1.26.20 is actually newer then version 2.2.2 which is a current requirement.

    Because there were some issues with version 2.0.* and 2.1.* other big projects (home assistant, one of the most popular project on github completely built in python) blocked urllib3 with <2.

    I would suggest to set the urllib3 dependency to urllib3 = ">=1.26.17,!2.0.*,!2.1.*" this will allow more people to utilize kiota, while still skipping the faulty versions and not blocking people from using >2.1 if they want

  7. baywet commented on Jan 20, 2025

    @baywet
    Member

    Thank you for the additional information.

    I think there's a serious mixing issue here.

    If you search for "urllib" you'll get about a dozen results, but this is misleading since the vast majority of them come from the BCL parse utils

    Searching for urllib3 instead only returns two results: the toml entry and the place where we set up the minimum TLS version for the client.

    This looks highly suspicious to me: using types from one HTTP client lib to setup properties on another lib. I think somebody got mixed up here.

    My suggestion is to:

    more context:

    Andrew Omondi (@andrueastman) I'd like your input on this one please.

  8. andrueastman commented on Jan 22, 2025

    @andrueastman
    Contributor

    My suggestion is to:

    +1 on this one really. I can't tell what the purpose of the poolmanager here as it isn't referenced anywhere else. Removing it and dropping the dependency would be the best here

    Would you be willing to make the changes here Stephan van Rooij (@svrooij) ?

  9. baywet commented on Jan 23, 2025

    @baywet
    Member

    (for others reading this svrooij shared with me that he is traveling for work/conferences at the moment, so this is likely to go to next week or maybe the following week, I'll remove the bot automation tags to reduce the noise here)

  10. added
    bugSomething isn't working
    type:bugA broken experience
    priority:p1High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days
    and removed
    type:questionAn issue that's a question
    on Jan 23, 2025
  11. moved this from Waits for author 🔁 to New📃 in Kiotaon Jan 23, 2025
  12. moved this from New📃 to Done ✔️ in Kiotaon Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    WIPbugSomething isn't workingpriority:p1High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7daystype:bugA broken experience

    Type

    Projects

    • Status
      Done ✔️

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions