Repository navigation
cpp/non-constant-format bug #27
Description
strings of the form L"..." are being marked as non-constant in cpp/non-constant-format-bug
In discussions with GitHub on a permanent fix they suggested an incremental fix approach:
- : Model
gettextfamily of string operations so flow can continue through these operations automatically: Model gettext family of string operations #50
Activity
bdrodes commentedon Nov 3, 2023
A deeper dive indicates the reported false positive for this is calling a macro that likely has string copy semantics into a arg of wprtinf, and that copy is not defined.
bdrodes commentedon Nov 3, 2023
The library in question are all strsafe operations from win32's api: https://learn.microsoft.com/en-us/windows/win32/api/strsafe/
These need to be modeled to fix the bug.
bdrodes commentedon Nov 8, 2023
I created this branch as a PR POC to github: https://github.com/microsoft/codeql/tree/27-cppnon-constant-format-bug
Merge pull request #27 from GitHubSecurityLab/refactor_astnode