Repository navigation
runtests-parallel does not fail when a single bucket fails - #8720
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoMay 20, 2016
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
Nathan Shively-Sanders (sandersn) merged 1 commit into
Conversation
Member
Author
|
Vladimir Matveev (@vladima) Daniel Rosenwasser (@DanielRosenwasser) here is the fix. |
Contributor
|
👍 |
Nathan Shively-Sanders (sandersn)
deleted the
runtests-parallel-does-not-fail-upon-failure
branch
May 20, 2016 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem that runtests-parallel has when tests from different buckets would fail -- only the failures from the first bucket would survive because Jake would fail when the first bucket failed.
Now all buckets run to completion, allowing you to see all failures at the end.