Skip to content

feat: add missing properties and JSX attributes code fixes - #64697

Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/64689
Open

Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/64689

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #64689

Copilot AI balanced review requested due to automatic review settings October 8, 2026 19:32
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Rest arguments and aliased enum or class values can produce missing or invalid fixes.

2 open findings

🧠 Review effort: Balanced

Comment thread tsc/internal/ls/codeactions_missingmemberfixer.go Outdated
Comment thread tsc/internal/ls/codeactions_addmissingproperties.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Generated fixes mishandle semantic JSX children, optional spread properties, and runtime references from type-only imports.

5 open findings
2 resolved since last review

🧠 Review effort: Balanced

Comment thread tsc/internal/ls/codeactions_missingmemberfixer.go Outdated
Comment thread tsc/internal/ls/codeactions_missingmemberfixer.go Outdated
Comment thread tsc/internal/ls/codeactions_missingmemberfixer.go Outdated
Comment thread tsc/internal/ls/codeactions_addmissingattributes.go Outdated
Comment thread tsc/internal/ls/codeactions_addmissingattributes.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Class defaults can generate invalid constructor calls for ambient, inherited, or inaccessible constructors.

0 open findings

5 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Use construct signatures to determine zero-argument constructibility

tsc/​internal/​ls/​codeactions_missingmemberfixer.go:619

This constructor check is based only on a constructor with a body, so ambient classes and derived classes with an inherited required constructor are treated as zero-argument constructible. For example, declare class C { constructor(x: string) } used as a required property is filled with new C, which immediately reports “Expected 1 argument”; private/protected constructors have a similar problem, while optional-parameter constructors are unnecessarily rejected. Determine zero-argument constructibility and accessibility from the class's construct signatures instead of the body declaration.

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad compiler, import-rewriting, content-mapping, and fix-all interactions warrant final human validation.

0 open findings

🧠 Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

TS 7 language server: "Add missing properties" quick fix not offered

2 participants