Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unconditional check incorrectly rejects erased ambient class declarations.
1 open finding
What changed in this PR
Adds strict-mode diagnostics for class names eval and arguments.
Changes:
- Checks class names during binding.
- Adds compiler regression coverage and diagnostic baselines.
| File | Description |
|---|---|
tsc/internal/binder/binder.go |
Adds class-name validation and class-specific diagnostics. |
tsc/testdata/tests/cases/compiler/strictModeEvalOrArgumentsInClassName.ts |
Adds regression cases. |
tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.errors.txt |
Records diagnostics. |
tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.symbols |
Records symbols. |
tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.types |
Records inferred types. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
|
||
| func (b *Binder) bindClassLikeDeclaration(node *ast.Node) { | ||
| name := node.Name() | ||
| b.checkStrictModeEvalOrArguments(node, name) |
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64661
bindClassLikeDeclarationdid not callcheckStrictModeEvalOrArguments, so class declarations and expressions namedevalorargumentsescaped TS1210. Call the check while binding class-like declarations and use the class-specific diagnostic for class names.Add regression coverage for class declarations, named class expressions, ambient class declarations, and JavaScript with
checkJs.Validation:
go -C ./tsc test '-run=TestLocal/(strictModeEvalOrArgumentsInClassName|strictModeReservedWordInClassDeclaration|argumentsReferenceInMethod4_Js)' ./internal/testrunnernpx hereby test,npx hereby lint, andnpx hereby check:formatwere not run.