Skip to content

Remove ES2018 transforms for ES2018 target - #26315

Merged
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
saschanaz:destruct-es2018
Feb 6, 2019
Merged

Remove ES2018 transforms for ES2018 target#26315
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
saschanaz:destruct-es2018

Conversation

@saschanaz

@saschanaz Kagami Sascha Rosylight (saschanaz) commented Aug 9, 2018

Copy link
Copy Markdown
Contributor

Fixes #20463

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2018

Copy link
Copy Markdown
Member

Seems like there should be a test to ensure that ES2018 actually preserves these features.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2018

Copy link
Copy Markdown
Member

Ron Buckton (@rbuckton) can you take a look at this PR?

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Aug 9, 2018

Copy link
Copy Markdown
Contributor Author

Daniel Rosenwasser (@DanielRosenwasser) Yeah... but where should the test go? Can you point an existing test which can be a guide?

rbuckton
Ron Buckton (rbuckton) reviewed Sep 27, 2018
View reviewed changes
Comment thread src/compiler/types.ts Resolved
@rbuckton Ron Buckton (rbuckton) mentioned this pull request Sep 28, 2018
Merged
@rbuckton

Ron Buckton (rbuckton) commented Sep 28, 2018

Copy link
Copy Markdown
Contributor

Kagami Sascha Rosylight (@saschanaz): You would likely need to move around some of the tests in tests/cases/conformance to align them with the correct ECMAScript edition.

@saschanaz
Kagami Sascha Rosylight (saschanaz) force-pushed the destruct-es2018 branch 3 times, most recently from 3e18658 to fda769d Compare October 27, 2018 05:16
@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Oct 27, 2018

Copy link
Copy Markdown
Contributor Author

I fixed the tests for async generator / for-await to correctly target es2018 instead of esnext.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Oct 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Couldn't replace @lib: esnext yet as it depends on #26220.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Nov 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

So it seems this is blocked again? #28354

@weswigham

Wesley Wigham (weswigham) commented Nov 6, 2018

Copy link
Copy Markdown
Member

That's TypeFlags not TransformFlags. Different enum.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Nov 6, 2018

Copy link
Copy Markdown
Contributor Author

Oops!

@weswigham

Wesley Wigham (weswigham) commented Nov 14, 2018

Copy link
Copy Markdown
Member

Ping Ron Buckton (@rbuckton) for review again - this looks pretty done. esnext just being optional catch clause right now is pretty great (sad it didn't make it on the 2018 train, would have made this even easier).

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Nov 14, 2018

Copy link
Copy Markdown
Contributor Author

Rebased with git file rename, now it should be easier to review commit-by-commit.

@fearthecowboy

Garrett Serack (fearthecowboy) commented Jan 29, 2019

Copy link
Copy Markdown

Is this going to make it in 3.3?

@weswigham
Wesley Wigham (weswigham) merged commit 6249b4c into microsoft:master Feb 6, 2019
@saschanaz
Kagami Sascha Rosylight (saschanaz) deleted the destruct-es2018 branch February 7, 2019 01:01
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@rbuckton Ron Buckton (rbuckton) rbuckton approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rbuckton Ron Buckton (rbuckton)

Labels

None yet

Projects

None yet

Milestone

TypeScript 3.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@saschanaz @DanielRosenwasser @rbuckton @weswigham @fearthecowboy @RyanCavanaugh