Repository navigation
rewriteRelativeImportExtensions does not rewrite the extension for an import expressions unless the file is detected to be a module #60599
Description
🔎 Search Terms
rewriteRelativeImportExtensions, import expression
🕗 Version & Regression Information
- This changed between versions 5.7
⏯ Playground Link
💻 Code
Test One
import('./foo.ts')Test Two
import './foo.ts';
import('./foo.ts')🙁 Actual behavior
JS Output
Test One
import('./foo.ts') // ❌Test Two
import './foo.js'; // ✅
import('./foo.js') // ✅🙂 Expected behavior
JS Output
Test One
import('./foo.js') // ✅Test Two
import './foo.js'; // ✅
import('./foo.js') // ✅Additional information about the issue
No response
Activity
jakebailey commentedon Nov 26, 2024
I don't think this has to do with the import being twice, but rather module detection? This one rewrites paths too: https://www.typescriptlang.org/play/?rewriteRelativeImportExtensions=true#code/JYWwDg9gTgLgBAcgHQHoBmEICYkwM4IDcAsAFCiSwAUy6muBAlGUA
bradzacher commentedon Nov 26, 2024
Looks like you might be right.
playground
This also correctly transforms the extension.
[-]rewriteRelativeImportExtensions does not rewrite the extension for an import expressions unless there is an import declaration for the same module[/-][+]rewriteRelativeImportExtensions does not rewrite the extension for an import expressions unless the file is detected to be a module[/+]jakebailey commentedon Nov 26, 2024
Andrew Branch (@andrewbranch)
jakebailey commentedon Nov 26, 2024
FWIW I'm not sure that this is incorrect behavior; this transformation was only intended on applying in modules, so if we don't think a file is a module, then it won't happen.
What condition are you running under where the file is not a module?
(Maybe we should rewrite imports in
importnodes in scripts, given they can appear there?)bradzacher commentedon Nov 26, 2024
If you're working in LTS node then the only way to access ESM in CJS is via
importexpressions.But it's not a real usecase I had in mind -- I was just testing the feature and this surprised me because there was no mention of it being restricted on the announcement, and there aren't docs yet (https://www.typescriptlang.org/tsconfig/#rewriteRelativeImportExtensions :sad:).
jakebailey commentedon Nov 26, 2024
To be clear a "module" to us means "not a global script"; CJS are modules in this scheme.