Repository navigation
getCurrentDirectory is marked as optional on LanguageServiceHost, but absence is an error #19278
Description
getCurrentDirectory is optional on LanguageServiceHost (as it inherits from GetEffectiveTypeRootsHost, and it is optional there), but calling createLanguageService with a host which does not implement getCurrentDirectory throws TypeError: host.getCurrentDirectory is not a function.
Activity
weswigham commentedon Oct 18, 2017
Mohamed Hegazy (@mhegazy) I don't think this is a breaking change. The change that made it optional was only comitted yesterday. Plus, we crash in
createLanguageServiceif you actually don't provide it, so...mhegazy commentedon Oct 18, 2017
oh, i see. i thought the fix was to change
GetEffectiveTypeRootsHost.getCurrentDirectorywhich is an overkill here.. you are correct. let's get this in then.