Skip to content

ARIAMixin properties should be nullable? #1119

New issue
New issue
Closed
Closed
ARIAMixin properties should be nullable?#1119

Description

@h-joo
Hana Joo (h-joo)
opened on Aug 25, 2021

In the ARIAMixin definition of TS 4.4-rc, the aria* properties are non-nullable, but according to the spec draft for AOM aria reflection with the AriaAttributes mixin, it seems to be nullable. Should these types need to be reconsidered to be nullable?

Activity

  1. orta commented on Aug 25, 2021

    @orta
    Orta Therox (orta)
    on Aug 25, 2021
    Contributor

    Linking to microsoft/TypeScript#45571

    It looks like this is defined upstream as not being nullable: https://github.com/w3c/webref/blob/master/ed/idlnames/ARIAMixin.idl - which does seem to match that spec https://www.w3.org/TR/wai-aria-1.2/#AriaAttributes

    I think I agree that this is probably something we want to be classed as optional properties though, not quite decided. What does it look like to hit an error with this?

  2. h-joo commented on Aug 25, 2021

    @h-joo
    Hana Joo (h-joo)
    on Aug 25, 2021
    Author

    We used to have Element-like interface implementation which used to have their own ariaLabel/ariaExpanded properties. The type of the two properties is string|undefined which now have problem on assignment to Element type as Element starts to extend from ARIAMixin as well with having the properties as a string type.

    Sample error message:

    TS2345: Argument of type 'X' is not assignable to parameter of type 'Element'.
  Types of property 'ariaExpanded' are incompatible.

  3. saschanaz commented on Aug 27, 2021

    @saschanaz
    Kagami Sascha Rosylight (saschanaz)
    on Aug 27, 2021
    Contributor

    So, per the spec, assigning undefined is wrong and it will be converted to a string "undefined".

  4. copybara-service
    added 3 commits that reference this issue on Sep 8, 2021

    (chore) Fix Typescript 4.4 compilation issues with aria properties

    91c0bd2

    (chore) Fix Typescript 4.4 compilation issues with aria properties

    de3fab3

    (chore) Fix Typescript 4.4 compilation issues with aria properties

    17d51f7

  5. jnurthen commented on Sep 17, 2021

    @jnurthen
    James Nurthen (jnurthen)
    on Sep 17, 2021

    Note w3c/aria#1611 makes them nullable again.

  6. saschanaz commented on Sep 17, 2021

    @saschanaz
    Kagami Sascha Rosylight (saschanaz)
    on Sep 17, 2021
    Contributor

    Thanks, in that case it will be updated by webref within a few days.

  7. saschanaz commented on Nov 14, 2021

    @saschanaz
    Kagami Sascha Rosylight (saschanaz)
    on Nov 14, 2021
    Contributor

    Fixed by #1200

    @github-actions close

  8. github-actions
    closed this as completedon Nov 14, 2021

  9. github-actions commented on Nov 14, 2021

    @github-actions
    github-actionsBot
    on Nov 14, 2021
    Contributor

    Closing because Kagami Sascha Rosylight (@saschanaz) is one of the code-owners of this repository.

  10. Aaron Gable (aarongable)
    added a commit that references this issue on Feb 15, 2022

    WebUI: Update TypeScript compiler to 4.5.5

    f875565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions