Repository navigation
FEAT: Add TapCodeConverter (tap_code converter) - #4444
Open
Roman Lutz (romanlutz) wants to merge 3 commits into
Open
Roman Lutz (romanlutz) wants to merge 3 commits into
Roman Lutz (romanlutz) wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The converter silently changes some non-ASCII characters into tap sequences because it uppercases them before checking for ASCII, violating its promised pass-through behavior.
1 open issue
What changed in this PR
Adds TapCodeConverter to PyRIT’s text transformation library and makes it available in the Garak Encoding scenario.
Changes:
- Implements tap-code encoding with configurable symbols and separators.
- Exports the converter and registers
tap_codeas an ALL-only encoding technique. - Adds converter tests, updates scenario expectations, and includes a Python documentation example.
| File | Description |
|---|---|
tests/unit/scenario/garak/test_encoding.py |
Updates technique counts and ALL-only expectations. |
tests/unit/converter/test_tap_code_converter.py |
Tests encoding, configuration, identifiers, and input validation. |
pyrit/scenario/scenarios/garak/encoding.py |
Registers the tap-code technique and converter variant. |
pyrit/converter/tap_code_converter.py |
Implements configurable tap-code conversion. |
pyrit/converter/__init__.py |
Adds the converter to public lazy exports. |
doc/code/converters/1_text_to_text_converters.py |
Adds a tap-code usage example. |
Review effort: Balanced
| """ | ||
| tokens: list[str] = [] | ||
| for char in text: | ||
| coordinate = self._coordinates.get(char.upper()) |
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds this converter as part of the gap-1 converter series (splitting the esoteric cipher / encoder set into per-converter and per-base PRs). Includes a unit test and garak Encoding-scenario registration; CI-validated locally.
Sibling PRs will be cross-linked once the series is open.
🤖 Generated with Claude Code
gap-1 converter series — splitting the esoteric cipher / encoder set into reviewable PRs (open each independently; they touch the same four registration files, so later ones rebase as earlier ones merge):