Skip to content

TEST: Assert concurrent-send independence without a latency budget - #4301

Merged
Roman Lutz (romanlutz) merged 1 commit into
microsoft:mainfrom
romanlutz:agents/fix-intermittent-unit-test-timeout
Nov 17, 2026
Merged

Roman Lutz (romanlutz) merged 1 commit into
microsoft:mainfrom
romanlutz:agents/fix-intermittent-unit-test-timeout

Conversation

@romanlutz

Copy link
Copy Markdown
Contributor

Description

Make the concurrent-send regression assert unrelated-send independence rather than a three-second completion budget. The first send stays gated until its unrelated peer finishes, so genuine serialization still fails.

  • Await the unrelated send directly, retaining the ordering and first-send-pending assertions and the existing ten-second hang watchdog.
  • Document the test's concurrency contract; change no production behavior, retry policy, or watchdog value.
  • A controlled event-loop clock advance at the second mocked conversation write reproduces the baseline cancellation stack and passes with this change; forcing serialized execution still fails the unchanged watchdog.

The macOS Python 3.12 failure on #4268 cancelled the unrelated send after it had acquired an execution slot, while awaiting a mocked conversation write. The exact cause of the historical runner delay remains unknown; this test does not execute real RPM throttling or conversion because its normalizer send is mocked. #3220 fixed a similar completion deadline in a different converter test, not this case.

Keep the first send gated until its unrelated peer finishes. Preserve the existing ordering assertions and ten-second hang watchdog.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 05:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the test-only update clarifying that unrelated sends can complete independently.

No open issues 🎉

What changed in this PR

Updates the backend concurrent-send regression test to verify that unrelated sends can complete independently, rather than within a fixed latency budget. No production behavior changes.

Changes:

  • Awaits the unrelated send directly, removing its three-second timeout.
  • Adds a docstring explaining the concurrency contract while preserving ordering checks, the first-send-pending assertion, and the existing ten-second hang watchdog.
File Description
tests/​unit/​backend/​test_message_send_service.py Replaces the completion deadline with a direct await and documents the independence requirement.

Review effort: Balanced

@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Nov 16, 2026
Merged via the queue into microsoft:main with commit 72158b0 Nov 17, 2026
59 checks passed
@romanlutz
Roman Lutz (romanlutz) deleted the agents/fix-intermittent-unit-test-timeout branch November 17, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants