Repository navigation
MAINT: validate SQL Server migrations - #4246
Merged
Behnam (behnam-o) merged 6 commits intoNov 13, 2026
Merged
Behnam (behnam-o) merged 6 commits into
Behnam (behnam-o) merged 6 commits into
Conversation
Exercise fresh and populated SQL Server upgrades on GitHub-hosted runners without Azure credentials. Keep migration repairs separate so the check exposes existing failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new SQL Server tests are blocked by an existing migration failure, requiring maintainer confirmation that the separate repair is included and GitHub-hosted execution succeeds before merging.
No open issues 🎉
What changed in this PR
Adds real SQL Server migration validation to PyRIT’s CI pipeline to catch database-specific failures before merge, including in the merge queue.
Changes:
- Adds a disposable SQL Server 2022 job with readiness checks, timeouts, and failure diagnostics.
- Adds fresh and populated-database migration tests covering retained data, relationships, Unicode, collation, repeat startup, and schema agreement.
- Documents local execution, coverage limits, and required-check configuration.
The PR remains blocked on the separate repair for the known Unicode dataset-name migration syntax error.
| File | Description |
|---|---|
tests/integration/memory/test_sqlserver_migrations_integration.py |
Adds isolated SQL Server migration and data-preservation tests. |
doc/contributing/4_running_tests.md |
Documents the migration check and maintainer setup. |
.github/workflows/build_and_test.yml |
Adds the SQL Server service and migration validation job. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove seeded historical-schema coverage and keep fresh-to-head migration execution plus schema comparison. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the migration check to a standalone build script so general integration pipelines do not require a disposable SQL Server. Preserve fail-closed configuration, schema validation and cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Behnam (behnam-o)
marked this pull request as ready for review
November 12, 2026 22:49
Richard Lundeen (richlundeen)
approved these changes
Nov 13, 2026
Richard Lundeen (richlundeen)
left a comment
Contributor
There was a problem hiding this comment.
Automated review completed. No blocking concerns remain. This review records source coverage; merging is handled separately.
Behnam (behnam-o)
deleted the
agents/ci-sqlserver-migration-check-pyrit
branch
November 13, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catch SQL Server migration errors before merge using a disposable SQL Server Developer container on GitHub-hosted CI.
Validated against real SQL Server after the separate fix in #4247; lint, type, and workflow checks pass.