Repository navigation
MAINT: Adopt noUncheckedIndexedAccess in frontend (#3729) - #3982
Merged
Roman Lutz (romanlutz) merged 3 commits intoNov 9, 2026
Merged
Roman Lutz (romanlutz) merged 3 commits into
Roman Lutz (romanlutz) merged 3 commits into
Conversation
Roman Lutz (romanlutz)
approved these changes
Nov 9, 2026
Resolve the retired History filter helper conflict and keep exact numeric rendering compatible with noUncheckedIndexedAccess. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the newly landed scenario execution ordering fix and regression tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #3729: implements Stage 1 (noUncheckedIndexedAccess).
This PR addresses Stage 1 of the frontend strict type-safety migration outlined by Roman Lutz (@romanlutz) in #3729:
"noUncheckedIndexedAccess": trueinfrontend/tsconfig.json.arr[0] ?? default,match?.[1] ?? '', andif (entry === undefined) return).exactOptionalPropertyTypesorstrict-type-checked).react-hooks/exhaustive-deps, with zero compiler or linter suppressions added.Tests and Documentation
Ran full frontend verification locally:
npm run type-check(npx tsc --noEmit): 0 errorsnpx tsc -p tsconfig.test.json --noEmit: 0 errorsnpm run lint: 0 errors, 0 warningsnpm run build: Vite production bundle built cleanlynpx jest): passed key suites covering modified modules (routeParams.test.ts,seedImport.test.ts,media.test.ts,conversationExport.test.ts,presetRunSizes.test.ts,attackAnalytics.test.ts,useChatConverters.test.tsx,useTour.test.ts,scenarioHierarchy.test.ts,scenarioMarkdown.test.ts,parameterForm.test.ts,AuthProvider.test.tsx,CreateTargetDialog.test.tsx,MessageList.test.tsx).