Repository navigation
FIX: Mark more credential parameters as sensitive - #3807
Merged
varunj-msft merged 2 commits intoNov 5, 2026
Merged
varunj-msft merged 2 commits into
varunj-msft merged 2 commits into
Conversation
The create forms showed the Azure Speech converters' azure_speech_key and HackAPromptTarget's cookie and session_id in plain text. The shared list of sensitive parameter names left them out, and the converter form's own text field ignored the flag. Add the three names, use a password field for sensitive converter parameters, and widen the credential-name checks so the target and converter registries flag the next one.
Richard Lundeen (richlundeen)
approved these changes
Nov 5, 2026
Richard Lundeen (richlundeen)
left a comment
Contributor
There was a problem hiding this comment.
Automated review completed. No blocking concerns remain. This review records source coverage; it does not authorize merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is one of the changes from the work on saving Registry entries across restarts. It doesn't depend on the rest of that work.
Problem. The create forms show the Azure Speech converters'
azure_speech_keyandHackAPromptTarget'scookieandsession_idin plain text./api/targets/typesand/api/converters/typesreport them assensitive: false, because the shared list of sensitive parameter names (ComponentIdentifier.get_sensitive_parameter_names, added in #2846) leaves them out. The converter form also has its own text field for plain parameters that ignores the flag.Change.
ParameterField.cookie,session_idand names ending in_key, and converters get the same check, so the next missed credential fails a test.What stays the same. Identifiers, hashes and stored data. The list only sets the
sensitiveflag in the type catalogs and keeps a converter's sensitive inputs out of its editable settings. Instance responses don't include these values today (the Speech key's type has no JSON form), so no response body changes beyond the flag. Non-sensitive converter fields still use a text field.Tests and Documentation
/api/targets/typesmarks HackAPrompt'scookieandsession_idsensitive and leaveschallenge_slugplain;/api/converters/typesmarksazure_speech_keysensitive and leavesazure_speech_regionplain for both Speech converters; the converter form renders a sensitive field as a password field and a plain one as text. Updated: the shared-list test (now also checks converters) and the target credential-name check. New: the converter credential-name check. Each new test fails without the change.pytest tests/unit/models/identifiers/test_typed_identifier.py tests/unit/registry/test_target_registry.py tests/unit/registry/test_converter_registry.py tests/unit/backend/test_api_routes.py::TestTargetRoutes tests/unit/backend/test_api_routes.py::TestConverterRoutes: 184 passed.npx jest src/components/Registry/CreateConverterDialog.test.tsx: 62 passed.npx eslint --max-warnings 0on the changed frontend files: clean.uv run --frozen --extra all --link-mode=copy ty check pyrit: all checks passed.pre-commit: passed./api/targets/typesand/api/converters/typesreportcookie,session_idandazure_speech_keyas sensitive on this branch and not on main;challenge_slugandazure_speech_regionstay plain on both.No documentation or JupyText changes.