Skip to content

MAINT: Type attack technique seed factories with Self - #3383

Merged
Roman Lutz (romanlutz) merged 2 commits into
microsoft:mainfrom
huong8373tt-beep:fix/p311-01-attack-technique-seed-group-self
Oct 21, 2026
Merged

Roman Lutz (romanlutz) merged 2 commits into
microsoft:mainfrom
huong8373tt-beep:fix/p311-01-attack-technique-seed-group-self

Conversation

@huong8373tt-beep

@huong8373tt-beep Slai.life (huong8373tt-beep) commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • update AttackTechniqueSeedGroup.from_system_prompt and from_messages to return Self
  • retain their existing cls(...) construction and runtime validation behavior
  • add subclass runtime and assert_type regression coverage for both factories

Validation

  • python -m pytest tests/unit/models/test_attack_technique_seed_group.py -q — 30 passed
  • python -m pre_commit run --files pyrit/models/seeds/attack_technique_seed_group.py tests/unit/models/test_attack_technique_seed_group.py
  • git diff --check origin/main...HEAD

Resolves the focused P311-01 AttackTechniqueSeedGroup factory-family investigation from #3166.

Slai Agent Runtime assisted with investigation, implementation, and testing. The account owner reviewed and authorized this contribution.

@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Oct 20, 2026
Merged via the queue into microsoft:main with commit 462f9a8 Oct 21, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants