Repository navigation
FIX: Filter scenario notebook inputs for ASCII smuggling - #2915
Merged
Nina Chikanov (nina-msft) merged 3 commits intoSep 30, 2026
Merged
Nina Chikanov (nina-msft) merged 3 commits into
Nina Chikanov (nina-msft) merged 3 commits into
Conversation
Filter incompatible seed groups before sampling while preserving the default technique set and selected objective text. Keep notebook sources synchronized and cover control characters, Unicode, and mixed groups. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d65728c-a1fd-4ace-8f7e-a337353ff787
Justin Song (jsong468)
approved these changes
Sep 29, 2026
Justin Song (jsong468)
left a comment
Contributor
There was a problem hiding this comment.
thanks for fixing!!
Rely on the existing notebook integration test, as requested in review. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d65728c-a1fd-4ace-8f7e-a337353ff787
Nina Chikanov (nina-msft)
enabled auto-merge
September 30, 2026 17:52
Nina Chikanov (nina-msft)
deleted the
nina-msft-azure-sql-integration-fix
branch
September 30, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The common scenario parameters notebook runs the default Foundry techniques, including ASCII smuggling, against randomly sampled HarmBench objectives. Objectives containing newlines cause
AsciiSmugglerConverterto reject the input and fail the notebook withScenarioPartialFailureException.Filter explicit seed groups to printable ASCII (0x20-0x7E) before sampling. This keeps the default technique example intact without rewriting objective text or weakening converter validation. The paired notebook and Python source remain synchronized, with existing notebook outputs preserved.
No breaking changes. Database permissions and secret updates discussed during investigation are not part of this PR.
Tests and Documentation
pytest tests/integration/scenarios/test_notebooks_scenarios.py -k 1_common_scenario_parameters- 1 passed, 4 deselected during initial validation. The successful local run used process-only Entra authentication after the existing local API-key configuration was rejected; saved credentials were not changed.Used Jupytext to confirm that the paired files have identical cell types and source content. Executed the notebook through the existing integration test with a worktree-local Python kernel.