Repository navigation
MAINT: extract attack factory converter configuration composition - #2799
Merged
Roman Lutz (romanlutz) merged 10 commits intoSep 26, 2026
Merged
Roman Lutz (romanlutz) merged 10 commits into
Roman Lutz (romanlutz) merged 10 commits into
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Roman Lutz (romanlutz)
requested changes
Sep 23, 2026
Roman Lutz (romanlutz)
approved these changes
Sep 25, 2026
Roman Lutz (romanlutz)
enabled auto-merge
September 25, 2026 14:21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #2767.
This PR extracts the existing converter-configuration composition logic from
AttackTechniqueFactory.create()into a small private typed helper.It preserves the existing distinction between full configuration replacement and additive request-converter composition while keeping the public API and existing factory behavior unchanged.
Specifically, this change:
AttackConverterConfig;supports_additional_request_converterscapability validation and constructor checks unchanged;No public signatures or component identity are intentionally changed.
Tests and Documentation
Focused factory tests cover:
The focused tests were introduced before the implementation change. After correcting one test-only assertion issue found during the initial run, the clean First-Red state contained one expected failure showing that
AttackTechniqueFactory.create()had not yet delegated composition to the private helper.The implementation was then changed without weakening that test.
Post-repair unit-test coverage passed across the relevant tested configurations. One recorded matrix run completed with:
No documentation changes are required because this is an internal refactor that preserves the public API and existing behavior.