Skip to content

Topological type generalizations - #2128

Merged
affeldt-aist merged 5 commits into
math-comp:masterfrom
nmolinamounier:topological-gen
Oct 14, 2026
Merged

affeldt-aist merged 5 commits into
math-comp:masterfrom
nmolinamounier:topological-gen

Conversation

@nmolinamounier

Copy link
Copy Markdown
Collaborator
Motivation for this change

Split from #2126 to contain only the generalization part.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist

affeldt-aist commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

You committed Makefiles (you may also want to not commit git configuration files).

@nmolinamounier

Copy link
Copy Markdown
Collaborator Author

The .gitignore change is somewhat intentional, these are files I have in my folder at all times and that I have to git rm constantly so they don't show up in commits (like the makefiles just did). I figure an ignore rule is the easiest way to take care of this, for me and for other contributors.

@affeldt-aist affeldt-aist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These are obviously desirable generalizations.

@affeldt-aist
affeldt-aist merged commit 37ea5ea into math-comp:master Oct 14, 2026
70 checks passed
@nmolinamounier
nmolinamounier deleted the topological-gen branch November 15, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants