Skip to content

open_nbhs -> mem_open - #2094

Open
affeldt-aist wants to merge 3 commits into
math-comp:masterfrom
affeldt-aist:fix_1969
Open

affeldt-aist wants to merge 3 commits into
math-comp:masterfrom
affeldt-aist:fix_1969

Conversation

@affeldt-aist

@affeldt-aist affeldt-aist commented Aug 30, 2026 •

Copy link
Copy Markdown
Member
Motivation for this change

fixes #1969

fixes #2050 already fixed

fyi: @CohenCyril @andrew-appel

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.18.0 milestone Aug 30, 2026
@affeldt-aist
affeldt-aist requested a review from mkerjean August 30, 2026 04:24
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Aug 30, 2026
Comment thread CHANGELOG_UNRELEASED.md Resolved

@mkerjean mkerjean left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the name change is welcomed. As long as the CI is green, it can be merged in my opinion (maybe once my comment about the changelog is clarified).

Comment thread CHANGELOG_UNRELEASED.md Resolved
@CohenCyril

CohenCyril commented Aug 30, 2026 •

Copy link
Copy Markdown
Member

From @mkerjean at #1969 (comment)

[open_nbhs_nbhs ] has a circular flavor : one can think that open_nbhs is the conjunction of open and nbhs and that the lemma looks circular.

open_nbhs is the conjunction of open and nbhs (as shown by open_nbhsE), just not definitionally as of now because there is a "simpler" definition. I'm wary of renaming it to mem_open knowing that it actually is more than that.

Something one could do instead is swap the definitional and propositional equality, i.e., have the statement
open_nbhs p = [set A in nbhs p | open A] be definitional and open_nbhs p A = open A /\ A p be propositional.
Because that's really the open neighborhoods of a point.

@CohenCyril CohenCyril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the name but change the definition, and write a lemma stating

Lemma open_nbhs_mem (p : T) (A : set T) : open_nbhs p A = open A /\ A p.

@affeldt-aist affeldt-aist modified the milestones: 1.18.0, 1.19.0 Sep 2, 2026
@affeldt-aist affeldt-aist modified the milestones: 1.19.0, 1.20.0 Oct 18, 2026
@affeldt-aist
affeldt-aist force-pushed the fix_1969 branch 2 times, most recently from bdcba82 to a6ba67e Compare November 4, 2026 18:15
@affeldt-aist

Copy link
Copy Markdown
Member Author

@CohenCyril your comments should have been addressed

@affeldt-aist

Copy link
Copy Markdown
Member Author

Since there was an issue, that it has been addressed, an approve and since comments have been addressed, I am considering merging this PR for the interest of the next release (ping me in case of problem).

by case: ifPn => [/set_mem/nPsA//|_]; exact: separable_set0.
Qed.

Lemma open_bigcup_basis (F : set_system T) (A : set T) :

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this theorem gone away?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!
No, it was renamed to basis_open_bigcup, to better match the order of the hypotheses.
This is a new lemma for the 1.20.0 release.
I have fixed the changelog.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename open_nbhs to mem_open Tell explicitly that nbhs stands for "neighborhoods"

3 participants