Repository navigation
open_nbhs -> mem_open - #2094
affeldt-aist wants to merge 3 commits into
Conversation
mkerjean
left a comment
There was a problem hiding this comment.
I agree that the name change is welcomed. As long as the CI is green, it can be merged in my opinion (maybe once my comment about the changelog is clarified).
|
From @mkerjean at #1969 (comment)
Something one could do instead is swap the definitional and propositional equality, i.e., have the statement |
CohenCyril
left a comment
There was a problem hiding this comment.
I would keep the name but change the definition, and write a lemma stating
Lemma open_nbhs_mem (p : T) (A : set T) : open_nbhs p A = open A /\ A p.bdcba82 to
a6ba67e
Compare
a6ba67e to
b8ec376
Compare
|
@CohenCyril your comments should have been addressed |
|
Since there was an issue, that it has been addressed, an approve and since comments have been addressed, I am considering merging this PR for the interest of the next release (ping me in case of problem). |
| by case: ifPn => [/set_mem/nPsA//|_]; exact: separable_set0. | ||
| Qed. | ||
|
|
||
| Lemma open_bigcup_basis (F : set_system T) (A : set T) : |
There was a problem hiding this comment.
Thanks for noticing!
No, it was renamed to basis_open_bigcup, to better match the order of the hypotheses.
This is a new lemma for the 1.20.0 release.
I have fixed the changelog.
Motivation for this change
fixes #1969
fixes #2050already fixedfyi: @CohenCyril @andrew-appel
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers