Repository navigation
Conversation
1fd5752 to
9b25fd0
Compare
9b25fd0 to
ee96fce
Compare
ee96fce to
429e727
Compare
429e727 to
952eba8
Compare
|
@CohenCyril we need your input for this PR some time this week if possible |
952eba8 to
de4f13a
Compare
|
I've implemented your recommendations and rebase the whole thing, now we can focus on the HB issues I think |
|
I want to see a more detailed motivation comment before reviewing the code changes. |
I have edited the first item of the conversation for that. |
t6s
left a comment
There was a problem hiding this comment.
I think the commented-out old codes should be removed.
If they were kept intentionally, I want to know the reason.
I have suggested a possible generalization of set1_bigcap_ball, but that is not necessary.
Other parts look good.
| Let mu : measure _ _ := @lebesgue_measure rT. | ||
| Import MeasurableR. | ||
| Let R : measurableType _ := measurableTypeR rT. | ||
| Let R : measurableType _ := (*measurableTypeR*) rT. |
There was a problem hiding this comment.
| Let R : measurableType _ := (*measurableTypeR*) rT. | |
| Let R : measurableType _ := rT. |
Other similar comments too.
| Section metric_archiRealFieldType. | ||
| Context {R : archiRealFieldType} {N : metricType R}. | ||
|
|
||
| Lemma set1_bigcap_ball (x : N) : [set x] = \bigcap_n ball x n.+1%:R^-1. |
There was a problem hiding this comment.
This lemma can be generalized to any strictly increasing functions, not just _.+1.
So that it can be used also for n^2 , 2^n, n!, etc.
Motivation for this change
The main goal of this PR is to introduce the module
MeasurableNormedModuleOpenthat equips a normed module
Nwith a sigma-algebra (of open sets).We want to do that to generalize the type of simple functions in
simple_functions.vto return in a normed module (instead of a
realType).The sigma-algebra for normed modules is kept in a module and therefore
available through an
Importcommand. (This is maybe not necessary and we willmaybe remove this limitation later once this PR has been tested against @Brixfoly's work.)
This PR also fixes the sigma-algebra of ¥bar R so that it builds from the sigma-algebra
of open sets of R instead of octiv (but this is an orthogonal issue with no impact on end-users).
This PR also removes several global hint that were barely used for clarity and renames
a couple of lemmas that had the same identifiers.
fyi @affeldt-aist @hoheinzollern
This PR is used in #2170 to developed bochner.v (not reviewed yet, just rebased).
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers