Skip to content

UTF-8 in labels causes problems #180

Open

Description

@PeterSurda

UTF-8 in labels (addressbooks, subscriptions, ...), like umlauts, does not display correctly. Also, it could be that if it is invalid UTF-8, the Bitmessage window does not show at all (one bug reporter), but I cannot reproduce that.

  • Editing a subscription in UI
  • Editing a subscription in SQL
  • Editing an addressbook entry in UI
  • Editing an addressbook entry in SQL
  • Editing an address label in UI
  • Editing an address label in SQL

Activity

  1. self-assigned this
    on Feb 25, 2016
  2. added this to the v0.5.x milestone on Feb 25, 2016
  3. Erkan-Yilmaz commented on Feb 25, 2016

    @Erkan-Yilmaz

    I tried and it seems I can reproduce it.

    1. OK:

    a. e.g. adding umlauts in the text of a message + subject works

    b. the umlaut is shown (also after receiving when I sent to myself this msg)

    but: when I add the umlaut in the address book as description (1) of the BM address:

    it discards the text and takes the original text (2) again

    (1) e.g. "erkan Nö"
    (2) "erkan"

    nothing more done than above 2 points, so I can at least try those again when a fix would be available

    using https://github.com/mailchuck/PyBitmessage v 0.5.7
    with commit: 2f9501f

  4. PeterSurda commented on Feb 25, 2016

    @PeterSurda
    CollaboratorAuthor

    That part I can reproduce too. But one guy reported that his PyBM does not start at all (the main QT thread crashes in rerenderSubscriptions) and that I can't reproduce.

  5. added 2 commits that reference this issue on Mar 12, 2016
  6. PeterSurda commented on Mar 12, 2016

    @PeterSurda
    CollaboratorAuthor

    @Erkan-Yilmaz can you try now? The UI should be fixed, just left is checking what happens if you manually create invalid utf8 in keys.dat or the database.

  7. Erkan-Yilmaz commented on Mar 12, 2016

    @Erkan-Yilmaz

    @PeterSurda I have tested my use case above ( "erkan äöü")
    OK: "erkan äöü" stays when I switch between tabs
    BUT: when I restart bitmessage it is again only "erkan"

    I am on commit c6b4237

  8. PeterSurda commented on Mar 12, 2016

    @PeterSurda
    CollaboratorAuthor

    @Erkan-Yilmaz what OS?

  9. Erkan-Yilmaz commented on Mar 12, 2016

    @Erkan-Yilmaz

    @PeterSurda I am sending this info right now to you via BM's support mail

  10. PeterSurda commented on Mar 13, 2016

    @PeterSurda
    CollaboratorAuthor

    I can't reproduce this (Windows and Linux). Are you editing an entry in the addressbook (rather than one of your own addresses)? The black ones in the "Send" tab?

  11. Erkan-Yilmaz commented on Mar 13, 2016

    @Erkan-Yilmaz

    yes, I was editing one of the "Address book" entries (1) from the Send tab (not the Address field which holds the BM-address)

    (1) which is also called "Label" when one creates a new contact

  12. PeterSurda commented on Apr 29, 2016

    @PeterSurda
    CollaboratorAuthor

    I'm sorry but I can't reproduce this. I'll postpone this until there is a more reliable way for me to reproduce.

  13. modified the milestones: v0.8.0, v0.5.x on Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions