Skip to content

Draw basal as 0 while a Trio pump is suspended - #800

Merged
marionbarker merged 1 commit into
devfrom
feature/basal-zero-during-pump-suspend
Nov 1, 2026
Merged

marionbarker merged 1 commit into
devfrom
feature/basal-zero-during-pump-suspend

Conversation

@bjorkert

@bjorkert bjorkert commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Trio uploads a PumpSuspend note when the pump suspends and a PumpResume note when it resumes, with no temp basal while suspended. The basal graph now pairs these notes and draws 0 in between, and the Basal info row shows 0 during an ongoing suspend. A suspend without a resume ends at the next temp basal, which covers pod changes where no resume is reported.

suspend-1

@bjorkert

Copy link
Copy Markdown
Member Author

Tested end to end in the simulator: Trio (dev) with MedtrumKit against a simulated Medtrum Nano, uploading to a local mock Nightscout that LoopFollow on this branch followed.

Suspended for 30 minutes at 20:36 and resumed at 20:48. Trio uploaded the PumpSuspend and PumpResume notes, the Basal row showed 0,8 → 0 during the suspend (left), and the graph draws 0 between the notes and the scheduled basal after the resume (right). The narrow bar at 20:35 is the temp basal the suspend cut short.

pr800-suspended pr800-after-resume

Not reproduced: a suspend without a resume ending at the next temp basal. In these runs both MedtrumKit and OmnipodKit uploaded a PumpResume at patch and pod changes, so that path is covered by the unit tests only.

@marionbarker marionbarker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by build, test with Loop URL and fact this is being used on developers phone who follows Trio URL.

@marionbarker
marionbarker merged commit 2bced0d into dev Nov 1, 2026
2 checks passed
@marionbarker
marionbarker deleted the feature/basal-zero-during-pump-suspend branch November 1, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants