Skip to content

fix: improve error message for exhausted blinded path route hints - #4398

Open
okekefrancis112 wants to merge 3 commits into
lightningdevkit:mainfrom
okekefrancis112:specific_routing_error_message
Open

okekefrancis112 wants to merge 3 commits into
lightningdevkit:mainfrom
okekefrancis112:specific_routing_error_message

Conversation

@okekefrancis112

Copy link
Copy Markdown
Contributor

This PR improves the routing error returned when attempting to pay a blinded (private) recipient and no route can be found. For Payee::Blinded, there is no public node ID or public graph path to the destination, meaning blinded path route hints are the only way to reach the payee. Previously, exhausting all provided blinded path hints resulted in the generic error “Failed to find a path to the given destination,” which is misleading. This change returns a more specific error indicating that all blinded path route hints were exhausted, while leaving behavior unchanged for Payee::Clear, where routing may still succeed via the public network graph even if route hints fail.

Closes: #4308

@ldk-reviews-bot

ldk-reviews-bot commented Feb 8, 2026 •

Copy link
Copy Markdown

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

@codecov

codecov Bot commented Feb 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (2424c4a) to head (2e8ad3c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4398      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.01%     
==========================================
  Files         156      156              
  Lines      103092   103105      +13     
  Branches   103092   103105      +13     
==========================================
+ Hits        88694    88698       +4     
- Misses      11885    11893       +8     
- Partials     2513     2514       +1     
Flag Coverage Δ
tests 86.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt
TheBlueMatt removed the request for review from valentinewallace February 9, 2026 13:09
Comment thread lightning/src/routing/router.rs Outdated

// Step (5).
if payment_paths.len() == 0 {
if matches!(payment_params.payee, Payee::Blinded { .. }) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? #4308 has nothing to do with blinded paths but rather with when we've tried every last-hop. Also this is the wrong check - at this point in the code we simply failed to find a path, you can't say anything about why.

@okekefrancis112 okekefrancis112 Mar 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? #4308 has nothing to do with blinded paths but rather with when we've tried every last-hop. Also this is the wrong check - at this point in the code we simply failed to find a path, you can't say anything about why.

Thanks for the review! (@TheBlueMatt) I understand the two issues:

  1. This should also cover Payee::Clear with route hints, not just Payee::Blinded
  2. At this point in the code we only know pathfinding failed, not why

For (2), would the right approach be to track inside add_entry! when route hint candidates (both blinded and private hop) are specifically rejected due to exhausted liquidity via used_liquidities, and only emit the specific error when that was the reason all hints failed? Or were you thinking of something simpler/different?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably detect it by looking at the route params which keeps track of previously-failed last-hops.

},
Payee::Clear { route_hints, .. } => {
!route_hints.is_empty()
&& route_hints.iter().all(|hint| {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we also need to check if the payee is a public node and if they are validate that we've attempted every channel which is not disabled to the payee. This would also allow us to return the useful error message even if route_hints is empty.

},
};
if all_hints_exhausted {
return Err("Failed to find a path to the given destination: all provided route hints have been exhausted by prior payment attempts");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Err("Failed to find a path to the given destination: all provided route hints have been exhausted by prior payment attempts");
return Err("All routes to the destination have been attempted and none succeeded. The payee is not payable, likely due to a lack of liquidity or being offline.");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specific routing error message for "cant try again because all the route hints to the node have been tried"

3 participants