Skip to content

scope.Close() in AsyncAfter #7

Open

Description

@juliangruber

shouldn't we close the scope in AsyncAfter since we also opened one?

Activity

  1. juliangruber commented on Nov 8, 2012

    @juliangruber
    Author
    scope.Close(Undefined());
  2. paulharris commented on Dec 7, 2012

    @paulharris

    I assume you mean
    return scope.Close(Undefined());

    I don't think you need to call scope.Close() unless you want to 'rescue' a handle from destruction from the HandleScope.

    In this case, I don't see why you would need to rescue the Undefined handle, it should just be

    return Undefined();

    // and let scope to clean up whatever handles it likes
    the undefined handle won't be cleaned up like other handles, as far as I know.... right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions