Repository navigation
Don't require JAVA_HOME to be set prior to install. #94
Description
I'm currently using node-java for webdriver-sync, and I want to make the install as smooth as possible.
A few areas for improvement I see are:
- Find java home if the environment variable isn't set and set it
- Find the path to binaries on windows instead of passing flags to node-gyp manually
I see this being possible in a preInstall script within package.json. Can I fork node-java to add that change? Would that be welcomed? If not I'll have to do that prep work within webdriver-sync.
Thanks for developing this!
Activity
jsdevel commentedon Dec 19, 2013
I published a module to npm to find java home: find-java-home
joeferner commentedon Dec 19, 2013
Sure anything that would make the install go smoother would be welcome.
Joe
Sent from my Samsung Epic™ 4G TouchJoseph Spencer notifications@github.com wrote:I'm currently using node-java for webdriver-sync, and I wan to make the install as smooth as possible.
A few areas for improvement I see are:
I see this being possible in a preInstall script within package.json. Can I fork node-java to add that change? Would that be welcomed? If not I'll have to do that prep work within webdriver-sync.
Thanks for developing this!
—
Reply to this email directly or view it on GitHub.
jsdevel commentedon Dec 19, 2013
Awesome. Can you assign this to me?
closes joeferner#94: Don't require JAVA_HOME to be set prior to install.
Merge pull request #95 from jsdevel/master