Skip to content

Infinite loop on windows #4

Closed
Closed
Infinite loop on windows#4

Description

@qwerbzuio
qwerbzuio
opened on Dec 18, 2019

rootpath.detect() runs infinitely on MS Windows if pattern can't be found. The used detection of the system root seems to be non-portable.

Potential fix: https://stackoverflow.com/a/12041606

Activity

  1. nagesh-chowdaiah commented on Oct 17, 2020

    @nagesh-chowdaiah
    nagesh-chowdaiah
    on Oct 17, 2020
    Contributor

    @qwerbzuio Can i work on this ticket?

  2. nagesh-chowdaiah commented on Oct 17, 2020

    @nagesh-chowdaiah
    nagesh-chowdaiah
    on Oct 17, 2020
    Contributor

    take

  3. nagesh-chowdaiah commented on Oct 17, 2020

    @nagesh-chowdaiah
    nagesh-chowdaiah
    on Oct 17, 2020
    Contributor

    @grimen I have fixed this issue, please let me to create the PR so that i can submit my changes

  4. nagesh-chowdaiah
    added 2 commits that reference this issue on Oct 18, 2020

    grimen#4 Rootpath: Fixed Infinite loop for windows

    1322aac

    grimen#4 Rootpath: Fixed Infinite loop for windows

    6883965
  5. grimen
    added a commit that references this issue on Mar 31, 2021

    #4 Rootpath: Fixed Infinite loop for windows

    ed6df33

  6. grimen commented on Mar 31, 2021

    @grimen
    grimen
    on Mar 31, 2021
    Owner

    Merged this PR, thank you.

  7. grimen
    closed this as completedon Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions