Skip to content

Shadow effect on layer should be applied to its children if fill is empty #169

Description

@softmarshmallow

Referring to images below, you can see the shadow on texts on origin design, but the output code renders shadow on it's container (div).

If the container (parent) has no fill, then the shadow effect should be applied to its children individually.
This issue is only dedicated to figma, how figma handles shadow on empty fill frames.

The possible solution for this would be altering tokens in tokenization stage, removing shadow effect from parent and applying it to its children. - I can't be sure if this is the best solution because it impacts the token tree itself.
The alternative is to handle this on post-tokenization step (which I cannot say where would be the best place to handle this.)

Origin design
Screen Shot 2022-07-25 at 11 46 01 AM

The output. (Now, wrong.)
Screen Shot 2022-07-25 at 11 47 08 AM

This is dedicated to figma platform.

ref: https://www.figma.com/file/iypAHagtcSp3Osfo2a7EDz/engine?node-id=4927%3A7312

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions