Skip to content

Draw distinction between bytes in blob_value (datastore property type) and large objects in GCS #329

Closed

Description

@dhermes

Per discussion today, we should rollback #263 and document that users should use cloud storage for blobs instead. Quickly scanning the code, another option would be to leave #263 in place but to document that it shouldn't be used for large byte strings and to potentially raise an error over a certain size. ISTM the code would fail if we tried to insert a blob that is large enough (10MB?).

True blob support is really an artifact of the old datastore implementation (just like GQL) which predates Cloud Storage.

Activity

  1. dhermes commented on Nov 3, 2014

    @dhermes
    ContributorAuthor

    UPDATE: From docs https://cloud.google.com/datastore/docs/concepts/entities a blob_value should be explicitly kept small.

    Up to 500 bytes if property is indexed, up to 1MB otherwise

  2. tseaver commented on Nov 12, 2014

    @tseaver
    Contributor

    I don't know if we have non-docstring docs for working with Entities, but some kind of "narrative" summary that covered them, poiting at the API docs for the concepts would be good. Showing how one might use storage for blob data, tracking keys in datastore, would be useful there.

  3. dhermes commented on Nov 12, 2014

    @dhermes
    ContributorAuthor

    I agree. May also be possible to point to existing docs with concepts.

    FWIW I'm not sure this bug is valid as currently named. It may be worthwhile for storing bytes in the datastore, just not files, images, etc.

  4. tseaver commented on Nov 12, 2014

    @tseaver
    Contributor

    Maybe change the title to "Document storing only small blobs in 'blob_value'"

  5. changed the title [-]Remove support for blob_value and document preferred usage[/-] [+]Draw distinction between bytes in blob_value (datastore property type) and large objects in GCS[/+] on Nov 12, 2014
  6. dhermes commented on Nov 12, 2014

    @dhermes
    ContributorAuthor

    I went a bit more verbose, WDYT?

  7. tseaver commented on Nov 12, 2014

    @tseaver
    Contributor

    Sounds fine.

  8. dhermes commented on Jan 27, 2015

    @dhermes
    ContributorAuthor

    Closing this and folding into #532 since the

    Up to 500 bytes if property is indexed, up to 1MB otherwise

    documentation is sufficient.

  9. modified the milestone: on Jan 30, 2015
  10. 29 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: datastoreIssues related to the Datastore API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions