Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem: When
load_skill_resourceexpands a binary function response in the final request content, its request processor drops every other part from that content. For example, a binary resource response and a sibling tool response merged into one content become only the binary resource response and its inline data.Solution: Preserve parts that are not binary responses from this tool. Keep the existing binary expansion in place and retain the original ordering of text, sibling responses, and existing inline data. Add regression coverage for mixed parts, repeated processing, and content with no binary resource response.
Testing Plan
Unit Tests:
Java 17, with Google Java formatting enabled:
The focused suite passed 15 tests in each of the
default-testandbasicexecutions. Full core completed with 2,017 tests, 0 failures, 0 errors, and 24 skipped in each of those two executions. The additional configured Surefire executions also completed successfully. The two main executions run the same suite; their counts are not added together as distinct tests.Manual End-to-End (E2E) Tests: Not run against a live model provider. The unit tests exercise the request processor directly with a mixed content payload and verify preserved order, function-response IDs, binary bytes, MIME type, and stable repeated processing.
Checklist
No new dependencies or public APIs are introduced.