Repository navigation
fix(cli): point runtime URLs and init templates at github/squad - #2412
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - The communications owner scans issues and discussions, drafts responses with the humanizer skill, and presents a review table for human approval. | ||
| - **Human review gate is mandatory** — the communications owner never posts autonomously. | ||
| - The communications owner scans issues and discussions, drafts responses with the humanizer skill, and presents a review table for human approval. | ||
| - **Human review gate is mandatory** — the communications owner never posts autonomously. |
Contributor
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ❌ | Not in draft | PR is still in draft — mark as ready for review when done |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 1 check(s) still running |
Files Changed (31 files, +334 −163)
| File | +/− |
|---|---|
.changeset/repo-move-github-squad-user-links.md |
+6 −0 |
.copilot/skills/github-multi-account/SKILL.md |
+11 −9 |
.squad-templates/session-init-reference.md |
+2 −2 |
.squad-templates/skills/external-comms/SKILL.md |
+1 −1 |
.squad-templates/skills/gh-auth-isolation/SKILL.md |
+2 −2 |
.squad-templates/skills/github-multi-account/SKILL.md |
+11 −9 |
.squad-templates/skills/pr-review-response/SKILL.md |
+10 −10 |
.squad-templates/skills/tiered-memory/SKILL.md |
+5 −5 |
packages/squad-cli/src/cli/core/init.ts |
+1 −1 |
packages/squad-cli/src/cli/upgrade.ts |
+1 −1 |
packages/squad-cli/templates/session-init-reference.md |
+2 −2 |
packages/squad-cli/templates/skills/external-comms/SKILL.md |
+18 −18 |
packages/squad-cli/templates/skills/gh-auth-isolation/SKILL.md |
+2 −2 |
packages/squad-cli/templates/skills/github-multi-account/SKILL.md |
+11 −9 |
packages/squad-cli/templates/skills/pr-review-response/SKILL.md |
+10 −10 |
packages/squad-cli/templates/skills/tiered-memory/SKILL.md |
+5 −5 |
packages/squad-sdk/src/config/init.ts |
+1 −1 |
packages/squad-sdk/src/state-backend.ts |
+1 −1 |
packages/squad-sdk/templates/session-init-reference.md |
+2 −2 |
packages/squad-sdk/templates/skills/external-comms/SKILL.md |
+18 −18 |
packages/squad-sdk/templates/skills/gh-auth-isolation/SKILL.md |
+2 −2 |
packages/squad-sdk/templates/skills/github-multi-account/SKILL.md |
+11 −9 |
packages/squad-sdk/templates/skills/pr-review-response/SKILL.md |
+10 −10 |
packages/squad-sdk/templates/skills/tiered-memory/SKILL.md |
+5 −5 |
templates/session-init-reference.md |
+2 −2 |
templates/skills/external-comms/SKILL.md |
+1 −1 |
templates/skills/gh-auth-isolation/SKILL.md |
+2 −2 |
templates/skills/github-multi-account/SKILL.md |
+11 −9 |
templates/skills/pr-review-response/SKILL.md |
+10 −10 |
templates/skills/tiered-memory/SKILL.md |
+5 −5 |
test/repo-links.test.ts |
+155 −0 |
Total: +334 −163
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review record identifies no remaining blockers after the canonical URL, template, and permission-based account-guidance updates were addressed.
No open issues 🎉
What changed in this PR
This pull request updates user-facing CLI/SDK URLs and squad init templates to use the repository’s new canonical location, github/squad, following the repository transfer. It also introduces repository-permission-based GitHub account guidance and regression coverage.
Changes:
- Updated CLI and SDK release, migration, error-reporting, and state-backend documentation URLs.
- Updated canonical templates and synchronized CLI, SDK, and root mirrors.
- Added repository-link regression tests and a patch changeset.
- Updated multi-account guidance to use repository push-permission checks; final review identified placeholder and rule-order issues in the canonical and repository-local copies.
| File | Description |
|---|---|
test/repo-links.test.ts |
Adds regression coverage for runtime URLs, template links, state-backend documentation, and account neutrality. |
templates/skills/tiered-memory/SKILL.md |
Synced tiered-memory issue links. |
templates/skills/pr-review-response/SKILL.md |
Synced GitHub API repository paths. |
templates/skills/github-multi-account/SKILL.md |
Synced permission-based account-selection guidance. |
templates/skills/gh-auth-isolation/SKILL.md |
Synced upstream repository examples. |
templates/skills/external-comms/SKILL.md |
Synced the example issue URL. |
templates/session-init-reference.md |
Synced release API and release-notes URLs. |
packages/squad-sdk/templates/skills/tiered-memory/SKILL.md |
SDK template mirror for tiered-memory links. |
packages/squad-sdk/templates/skills/pr-review-response/SKILL.md |
SDK template mirror for review-response API paths. |
packages/squad-sdk/templates/skills/github-multi-account/SKILL.md |
SDK template mirror for account-selection guidance. |
packages/squad-sdk/templates/skills/gh-auth-isolation/SKILL.md |
SDK template mirror for upstream repository examples. |
packages/squad-sdk/templates/skills/external-comms/SKILL.md |
SDK template mirror for the example issue URL. |
packages/squad-sdk/templates/session-init-reference.md |
SDK template mirror for release links. |
packages/squad-sdk/src/state-backend.ts |
Fixes the git-notes migration documentation link. |
packages/squad-sdk/src/config/init.ts |
Updates the SDK template-drift reporting URL. |
packages/squad-cli/templates/skills/tiered-memory/SKILL.md |
CLI template mirror for tiered-memory links. |
packages/squad-cli/templates/skills/pr-review-response/SKILL.md |
CLI template mirror for review-response API paths. |
packages/squad-cli/templates/skills/github-multi-account/SKILL.md |
CLI template mirror for account-selection guidance. |
packages/squad-cli/templates/skills/gh-auth-isolation/SKILL.md |
CLI template mirror for upstream repository examples. |
packages/squad-cli/templates/skills/external-comms/SKILL.md |
CLI template mirror for the example issue URL. |
packages/squad-cli/templates/session-init-reference.md |
CLI template mirror for release links. |
packages/squad-cli/src/cli/upgrade.ts |
Updates the CLI release URL. |
packages/squad-cli/src/cli/core/init.ts |
Updates the .ai-team/ migration notice URL. |
.squad-templates/skills/tiered-memory/SKILL.md |
Updates canonical tiered-memory issue links. |
.squad-templates/skills/pr-review-response/SKILL.md |
Updates canonical review-response API paths. |
.squad-templates/skills/github-multi-account/SKILL.md |
Adds permission-based account selection; its executable snippet still contains literal account placeholders, and an earlier owner-based rule can bypass the permission check. |
.squad-templates/skills/gh-auth-isolation/SKILL.md |
Updates canonical upstream repository examples. |
.squad-templates/skills/external-comms/SKILL.md |
Updates the canonical example issue URL. |
.squad-templates/session-init-reference.md |
Updates canonical release API and release-notes URLs. |
.copilot/skills/github-multi-account/SKILL.md |
Updates repository-local account guidance; its executable snippet still contains literal account placeholders. |
.changeset/repo-move-github-squad-user-links.md |
Records patch releases for the CLI and SDK packages. |
Review effort: Lite (auto)
tamirdresher
force-pushed
the
squad/2404-cli-sdk-template-links
branch
from
November 8, 2026 14:27
7155bf9 to
d7f698b
Compare
Contributor
🟠 Impact Analysis — PR #2412Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affectedcopilot-config (1 file)
root (7 files)
squad-cli (8 files)
squad-sdk (8 files)
templates (6 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
- squad upgrade release URL, the .ai-team migration notice and the SDK's report URL - state-backend docs link (also fixes a pre-existing 404) - squad init templates: session-init-reference, gh-auth-isolation, pr-review-response, external-comms, tiered-memory, github-multi-account - test/repo-links.test.ts guards user-facing links Closes #2404 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…i-account This PR replaced the hardcoded repo binding with a push-permission check, but usage rule 3 still chose the alias by repo owner, and the Step 5 message to the user said the same, so the skill contradicted itself (flagged in Copilot review). Point rule 3 at the permission check and reword the Step 5 message to match. Synced to the root, CLI and SDK template mirrors and the repo-local copy. Refs #2404 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tamirdresher
force-pushed
the
squad/2404-cli-sdk-template-links
branch
from
November 8, 2026 18:42
d7f698b to
49a4b0f
Compare
Collaborator
Author
|
Added 49a4b0f after Copilot's review. The account-selection guidance in Validation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Points user-facing CLI/SDK URLs, and the templates that
squad initinstalls, atgithub/squad:squad upgraderelease URL, the.ai-team/migration notice, the SDK's "please report it at" URL, and the state-backend docs link.test/repo-links.test.tsguards these links.Working as cli-dev (CLI Engineer).
Why
After the transfer, users were sent to the old repository for releases, issues, and docs. The templates also copied old-repository API paths into users' repos. The state-backend link pointed at
docs/state-backends.md, a path that never existed, so it was already a 404.Closes #2404
How
.squad-templates/files were edited. The 3 mirrors were synced withnode scripts/sync-templates.mjs --sync, sotemplate-synckeeps them byte-identical.packages/squad-cli/src/cli/core/init.tsis a protected bootstrap file. Only one string changed, and no imports were added.bradygaster/squad#NNNreferences, including the link text in tiered-memory; only the URLs changedsource:provenance frontmatterindex.cjs/cli.jsmessages aboutnpx github:bradygaster/squadSize (>20 files): 31 files:
Validation (branch on its own, Windows, Node 27):
npx vitest run test/repo-links.test.ts test/template-sync.test.ts test/recast-identity-neutrality.test.ts test/state-backend.test.ts test/init-sdk.test.ts test/cli.test.tscli,init-sdk, andstate-backendtimed out while other suites ran in paralleltest/cli.test.ts test/init-sdk.test.ts test/state-backend.test.tsalonenpm run lintSKIP_BUILD_BUMP=1 npm run buildrepo-linkstests fail against the old content, naming 19 file:line hitsThe other repo-move PRs are #2406, #2407, #2403, and #2405 (issues).
npx changeset add/.changeset/*.md, directCHANGELOG.mdentry for maintainers, orskip-changeloglabel for no user-facing changes)PR Readiness Checklist
Branch & Commit
dev(notmain)dev(git fetch upstream && git rebase upstream/dev)git diff --cached --stat)Build & Test
npm run buildpassesnpm testpasses (all tests green): targeted suites above; the full suite runs in CInpm run lintpasses (type check clean)npm run lint:eslintpassesChangeset
npx changeset add(ifpackages/squad-sdk/src/orpackages/squad-cli/src/changed):.changeset/repo-move-github-squad-user-links.mdCHANGELOG.mdentry (maintainers only — write-protected for external contributors)skip-changeloglabel applied (if no user-facing changes)Docs
Exports
Breaking Changes
None.
Waivers
None.