Skip to content

fix(release): point package and NuGet metadata at github/squad - #2408

Merged
tamirdresher merged 1 commit into
devfrom
squad/2406-repo-move-release-metadata
Nov 8, 2026
Merged

tamirdresher merged 1 commit into
devfrom
squad/2406-repo-move-release-metadata

Conversation

@tamirdresher

Copy link
Copy Markdown
Collaborator

What

Points package, NuGet, and release-packaging metadata at github/squad after the repository transfer from bradygaster/squad. This covers homepage, bugs, and repository in the root, CLI, and SDK package.json files and in the SDK's package generator; Squad.Agents.AI project/repository URLs and its README links; the install.sh and generate-packaging.mjs defaults; the WinGet DocumentUrl (the new docs host); the release closure record; and the WinGet PR release link, which is now built from GITHUB_SERVER_URL/GITHUB_REPOSITORY. A new test/publish-repository-identity.test.ts fails if published metadata stops matching the repository.

Working as release-engineer (Release Engineer).

Why

squad-npm-publish.yml publishes with --provenance, and npm rejects a provenance publish when repository.url doesn't match the source repository. The next npm release would fail. NuGet and installer defaults also still name the old owner.

Closes #2406

How

  • Changes only the repository location. These stay as they are: the npm scope @bradygaster/*, WinGet IDs bradygaster.Squad* and PublisherUrl (the publisher is Brady), the Homebrew tap bradygaster/homebrew-squad (it didn't move), and the release-manifest schema $id. Changing the $id would change the schema hash that validate-manifest.mjs --provenance checks for already-published evidence bundles.
  • The few workflow edits (a comment, a ruleset URL, and the release link) belong to the same metadata change, so they aren't split into a separate infra PR.
  • Maintainer action: at nuget.org Trusted Publishing, add a policy with Owner github, Repository squad, Workflow squad-agents-ai-release.yml, and no environment. Then retire the bradygaster policy.
  • This fix must also reach main before any publish from main.

Validation (branch on its own, Windows, Node 27):

Command Result
npx vitest run test/publish-repository-identity.test.ts test/bundle.test.ts test/standalone-build.test.ts test/packaging-manifests.test.ts test/standalone-release-workflow.test.ts test/release-policy-changeset-drain.test.ts ✅ 6 files, 177 passed
npm run lint ✅ passed
SKIP_BUILD_BUMP=1 npm run build ✅ passed
npm run lint:eslint (all 5 repo-move PRs combined) ✅ 0 errors (existing warnings only)
Red proof: source edits reverted ✅ 18 failures, each naming the stale value

The other repo-move PRs are #2407, #2403, #2405, and #2404 (issues).


⚠️ Quick Check

  • If SDK/CLI source files changed: completed the applicable Changeset step below (npx changeset add / .changeset/*.md, direct CHANGELOG.md entry for maintainers, or skip-changelog label for no user-facing changes)

PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

  • Branch created from dev (not main)
  • Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
  • Verified diff contains only intended changes (git diff --cached --stat)
  • PR is not in draft mode (mark ready when checks pass)
  • Commit history is clean (squash fixups before review)

Build & Test

  • npm run build passes
  • npm test passes (all tests green): targeted suites above; the full suite runs in CI
  • npm run lint passes (type check clean)
  • npm run lint:eslint passes
  • For migration PRs (>20 files): include test output summary in PR description: N/A (19 files)

Changeset

  • Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed): .changeset/repo-move-github-squad-package-metadata.md
  • Or direct CHANGELOG.md entry (maintainers only — write-protected for external contributors)
  • Or skip-changelog label applied (if no user-facing changes)

Docs

Exports

  • package.json subpath exports updated (if new module): N/A, no new modules

Breaking Changes

None.

Waivers

None.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 180cbe4

PR Scope: 📦🔧 Mixed (product + infrastructure)

⚠️ 2 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 1 check(s) still running

Files Changed (19 files, +165 −37)

File +/−
.changeset/repo-move-github-squad-package-metadata.md +6 −0
.github/workflows/squad-agents-ai-release.yml +1 −1
.github/workflows/squad-ci.yml +1 −1
.github/workflows/squad-standalone-release.yml +1 −1
package.json +3 −3
packages/squad-cli/package.json +3 −3
packages/squad-sdk/package.json +3 −3
packages/squad-sdk/src/build/github-dist.ts +1 −1
packages/squad-sdk/src/build/npm-package.ts +1 −1
scripts/generate-packaging.mjs +4 −3
scripts/install.sh +3 −3
scripts/release/closure-items.json +2 −2
src/Squad.Agents.AI/README.md +5 −5
src/Squad.Agents.AI/Squad.Agents.AI.csproj +2 −2
test/bundle.test.ts +15 −6
test/packaging-manifests.test.ts +41 −1
test/publish-repository-identity.test.ts +62 −0
test/standalone-build.test.ts +8 −1
test/standalone-release-workflow.test.ts +3 −0

Total: +165 −37


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

The repo moved from bradygaster/squad to github/squad. npm rejects a
--provenance publish when package.json repository.url doesn't match the
source repository, so the next release would fail.

- package.json (root, cli, sdk) and the SDK package generator: homepage,
  bugs and repository point at github/squad
- Squad.Agents.AI: PackageProjectUrl, RepositoryUrl and README links
- install.sh and generate-packaging.mjs default to github/squad; the
  WinGet DocumentUrl uses the new docs host; release links derive from
  GITHUB_SERVER_URL/GITHUB_REPOSITORY
- test/publish-repository-identity.test.ts guards published metadata

Kept: npm scope, WinGet IDs and PublisherUrl, Homebrew tap, schema $id.

Closes #2406

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tamirdresher
tamirdresher force-pushed the squad/2406-repo-move-release-metadata branch from 840f862 to 180cbe4 Compare November 8, 2026 14:07
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

🟠 Impact Analysis — PR #2408

Risk tier: 🟠 HIGH

📊 Summary

Metric Count
Files changed 19
Files added 2
Files modified 17
Files deleted 0
Modules touched 6
Critical files 3

🎯 Risk Factors

  • 19 files changed (6-20 → MEDIUM)
  • 6 modules touched (5-8 → HIGH)
  • Critical files touched: package.json, packages/squad-cli/package.json, packages/squad-sdk/package.json

📦 Modules Affected

ci-workflows (3 files)
  • .github/workflows/squad-agents-ai-release.yml
  • .github/workflows/squad-ci.yml
  • .github/workflows/squad-standalone-release.yml
root (4 files)
  • .changeset/repo-move-github-squad-package-metadata.md
  • package.json
  • src/Squad.Agents.AI/README.md
  • src/Squad.Agents.AI/Squad.Agents.AI.csproj
scripts (3 files)
  • scripts/generate-packaging.mjs
  • scripts/install.sh
  • scripts/release/closure-items.json
squad-cli (1 file)
  • packages/squad-cli/package.json
squad-sdk (3 files)
  • packages/squad-sdk/package.json
  • packages/squad-sdk/src/build/github-dist.ts
  • packages/squad-sdk/src/build/npm-package.ts
tests (5 files)
  • test/bundle.test.ts
  • test/packaging-manifests.test.ts
  • test/publish-repository-identity.test.ts
  • test/standalone-build.test.ts
  • test/standalone-release-workflow.test.ts

⚠️ Critical Files

  • package.json
  • packages/squad-cli/package.json
  • packages/squad-sdk/package.json

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

Authoritative evidence: scanners from the PR base commit, posted by the default-branch workflow_run reporter.
Results for head commit 180cbe4c89846da348070382d1de458319b69128.

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

@tamirdresher
tamirdresher marked this pull request as ready for review November 8, 2026 14:18
Copilot AI auto review requested due to automatic review settings November 8, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Approval depends on external NuGet Trusted Publishing configuration that must be updated and verified outside this diff before release.

No open issues 🎉

What changed in this PR

Updates package, NuGet, installer, packaging, and release metadata to reference the repository’s new canonical location, github/squad, following the repository transfer.

Changes:

  • Updated npm, NuGet, installer, packaging, documentation, and release URLs.
  • Replaced hardcoded release links with repository-aware GitHub Actions variables.
  • Added regression coverage for repository identity and packaging defaults.
  • Added a changeset for the package metadata updates.
File Reviewed changes
test/​standalone-release-workflow.test.ts Verifies release links use the current repository context.
test/​standalone-build.test.ts Verifies installer documentation and defaults use github/squad.
test/​publish-repository-identity.test.ts Validates npm and NuGet metadata against the canonical repository.
test/​packaging-manifests.test.ts Validates repository, documentation, and packaging URLs.
test/​bundle.test.ts Covers updated package and distribution defaults.
src/​Squad.Agents.AI/​Squad.Agents.AI.csproj Updates NuGet project and repository URLs.
src/​Squad.Agents.AI/​README.md Updates NuGet package repository links.
scripts/​release/​closure-items.json Updates release closure repository references.
scripts/​install.sh Updates installer documentation and repository defaults.
scripts/​generate-packaging.mjs Updates packaging defaults and WinGet documentation URLs.
packages/​squad-sdk/​src/​build/​npm-package.ts Updates generated npm repository metadata; the public generator output still omits homepage and bugs.
packages/​squad-sdk/​src/​build/​github-dist.ts Updates the default GitHub distribution owner.
packages/​squad-sdk/​package.json Updates SDK package metadata URLs.
packages/​squad-cli/​package.json Updates CLI package metadata URLs.
package.json Updates root package metadata URLs.
.github/​workflows/​squad-standalone-release.yml Makes WinGet release links repository-aware.
.github/​workflows/​squad-ci.yml Updates the documented ruleset URL.
.github/​workflows/​squad-agents-ai-release.yml Documents the new NuGet Trusted Publishing owner.
.changeset/​repo-move-github-squad-package-metadata.md Records the package metadata patch release.

This pull request requires changes.

Review effort: Lite (auto)

@tamirdresher
tamirdresher merged commit bf8136f into dev Nov 8, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repo move: point npm, NuGet and release metadata at github/squad

3 participants