Skip to content

Recast repository with descriptive Squad specialists - #2030

Merged
bradygaster merged 3 commits into
devfrom
bradygaster-recast-descriptive-squad
Sep 13, 2026
Merged

bradygaster merged 3 commits into
devfrom
bradygaster-recast-descriptive-squad

Conversation

@bradygaster

@bradygaster bradygaster commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

What

Replaces the retired Mission Control team state with a fresh descriptive cast of 18 accountable specialists, four bounded support identities, regenerated coordinator state, and a public roster. It also updates the Cast and upgrade templates so future casts and upgrades preserve this structure instead of reintroducing retired histories or orchestration behavior.

Why

The previous local Squad state had accumulated historical team identities and runtime artifacts that no longer represented the repository's current architecture. The initial recast exposed product-level durability gaps: normal Cast and upgrade paths could overwrite the coordinator, recreate histories, merge support agents into the routable roster, and remove the explicit Coding Agent state. This PR fixes those paths so the clean recast remains reproducible.

Part of #2009

How

  • Recast the repository around 18 descriptive specialists with matching registry, routing, and charters.
  • Added team-owned governance for accountable ownership, bounded review gates, independent rereview, and escalation.
  • Added a deferred nine-part onboarding protocol; onboarding is defined but not executed by this PR.
  • Updated createTeam() to materialize canonical built-in charters, keep support identities outside the specialist registry/routing table, preserve the disabled Coding Agent section, and stop creating retired per-agent histories.
  • Updated canonical coordinator and roster template mirrors so upgrades retain explicit Cast sources and bounded ownership instead of eager anticipatory fan-out.
  • Synchronized Scribe, Ralph, Rai, and Fact Checker charter templates across CLI, SDK, workflow, and installed-template surfaces.
  • Restored the standard casting policy while keeping descriptive naming as the default.
  • Retained cleaned team-local model selection, work monitoring, and decision-maintenance procedures; retired DispatchGuard and stale team-specific skills.
  • Intentionally removed old alumni, histories, session logs, prototypes, hooks, and other superseded .squad/ state. The large deletion count is the core migration, not unrelated cleanup.

Validation completed:

  • squad health --json passes.
  • Registry, routing, specialist directories, onboarding references, and governance references validate at 18/18/18.
  • Coordinator, roster, and built-in charter template mirrors are byte-identical across their governed copies.
  • Materialized built-in charters match the workflow canonical resources.
  • Focused contract checks verify explicit Cast sources, bounded ownership, support-agent separation, disabled Coding Agent state, and absence of per-agent history generation.
  • git diff --check passes with the repository's CRLF allowance for cast.ts.
  • Dependency-based Vitest/typecheck execution was attempted after configuring the required corporate proxy, then retried against the public npm registry with an isolated cache. The proxy lacks @typescript-eslint/visitor-keys@8.70.0, and npm subsequently failed with Exit handler never called!; CI remains the executable validation path.

⚠️ Quick Check

  • If SDK/CLI source files changed: completed the applicable Changeset step below (npx changeset add / .changeset/*.md, direct CHANGELOG.md entry for maintainers, or skip-changelog label for no user-facing changes)

PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

  • Branch created from dev (not main)
  • Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
  • Verified diff contains only intended changes (git diff --cached --stat)
  • PR is not in draft mode (mark ready when checks pass)
  • Commit history is clean (squash fixups before review)

Build & Test

  • npm run build passes - blocked locally by npm dependency restoration failure documented above
  • npm test passes (all tests green) - blocked locally by npm dependency restoration failure documented above
  • npm run lint passes (type check clean) - blocked locally by npm dependency restoration failure documented above
  • npm run lint:eslint passes - blocked locally by npm dependency restoration failure documented above
  • For migration PRs (>20 files): include test output summary in PR description

Changeset

  • Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed)
  • Or direct CHANGELOG.md entry (maintainers only - write-protected for external contributors) - N/A
  • Or skip-changelog label applied (if no user-facing changes) - N/A

Docs

  • README section updated (if new feature/module) - N/A; this changes Cast persistence semantics, not a new user-facing module
  • Docs feature page (if new user-facing capability) - N/A

Exports

  • package.json subpath exports updated (if new module) - N/A

Breaking Changes

None. Existing Cast commands retain their interface; generated state is made consistent with the current support-agent and persistence contracts.

Waivers

N/A. Build, test, and lint remain unchecked rather than waived; CI can provide repository-level validation.

Replace the retired Mission Control team state with the validated descriptive specialist cast and retained team procedures.\n\nPart of #2009\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 13, 2026 05:37
@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 4a37de0

PR Scope: 📦🔧 Mixed (product + infrastructure)

⚠️ 2 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean ⚠️ PR includes 238 .squad/ file(s) — ensure these are intentional
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved 6 active Copilot thread(s) resolved (4 outdated skipped)
✅ CI passing All checks passing

Files Changed (278 files, +2597 −32324)

File +/−
.changeset/calm-casts-preserve-support.md +6 −0
.github/agents/squad.agent.md +78 −119
.github/skills/iterative-retrieval/SKILL.md +0 −0
.github/skills/reflect/SKILL.md +0 −0
.squad-templates/fact-checker-charter.md +31 −54
.squad-templates/rai-charter.md +30 −73
.squad-templates/ralph-charter.md +11 −0
.squad-templates/roster.md +9 −2
.squad-templates/scribe-charter.md +23 −138
.squad-templates/squad.agent.md +78 −119
.squad/.first-run +1 −1
.squad/agents/_alumni/baer/charter.md +0 −33
.squad/agents/_alumni/breedan/charter.md +0 −33
.squad/agents/_alumni/cheritto/charter.md +0 −26
.squad/agents/_alumni/drucker/charter.md +0 −347
.squad/agents/_alumni/edie/charter.md +0 −36
.squad/agents/_alumni/fenster/charter.md +0 −36
.squad/agents/_alumni/fortier/charter.md +0 −36
.squad/agents/_alumni/hockney/charter.md +0 −34
.squad/agents/_alumni/keaton/charter.md +0 −37
.squad/agents/_alumni/kobayashi/charter.md +0 −165
.squad/agents/_alumni/kobayashi/history.md +0 −39
.squad/agents/_alumni/kovash/charter.md +0 −38
.squad/agents/_alumni/kujan/charter.md +0 −33
.squad/agents/_alumni/marquez/charter.md +0 −30
.squad/agents/_alumni/mcmanus/charter.md +0 −42
.squad/agents/_alumni/nate/charter.md +0 −28
.squad/agents/_alumni/rabin/charter.md +0 −34
.squad/agents/_alumni/redfoot/charter.md +0 −34
.squad/agents/_alumni/saul/charter.md +0 −35
.squad/agents/_alumni/strausz/charter.md +0 −33
.squad/agents/_alumni/trejo/charter.md +0 −179
.squad/agents/_alumni/verbal/charter.md +0 −34
.squad/agents/_alumni/waingro/charter.md +0 −26
.squad/agents/agent-orchestration-dev/charter.md +22 −0
.squad/agents/agentic-workflows-dev/charter.md +22 −0
.squad/agents/architect/charter.md +22 −0
.squad/agents/booster/charter.md +0 −28
.squad/agents/booster/history-archive-2026-08-19T13-11-34.130-07-00.md +0 −225
.squad/agents/booster/history.md +0 −150
.squad/agents/capcom/charter.md +0 −28
.squad/agents/capcom/history.md +0 −69
.squad/agents/cli-dev/charter.md +22 −0
.squad/agents/control/charter.md +0 −28
.squad/agents/control/history.md +0 −53
.squad/agents/docs-devrel/charter.md +22 −0
.squad/agents/dotnet-agent-framework-dev/charter.md +22 −0
.squad/agents/dsky/charter.md +0 −28
.squad/agents/eecom/charter.md +0 −28
.squad/agents/eecom/history-archive-2026-08-19T13-11-34.130-07-00.md +0 −529
... +228 more files

Total: +2597 −32324


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

⚠️ Architectural review: 2 warning(s).

Severity Category Finding Files
🟡 warning bootstrap-area 2 file(s) in the bootstrap area (packages/squad-cli/src/cli/core/) were modified. These files must maintain zero external dependencies. Review carefully. packages/squad-cli/src/cli/core/cast.ts, packages/squad-cli/src/cli/core/templates.ts
🟡 warning sweeping-refactor This PR touches 278 files (94 modified/added, 184 deleted). Large PRs are harder to review — consider splitting if possible. —

Automated architectural review — informational only.

@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🔴 Impact Analysis — PR #2030

Risk tier: 🔴 CRITICAL

📊 Summary

Metric Count
Files changed 278
Files added 29
Files modified 65
Files deleted 184
Modules touched 7

🎯 Risk Factors

  • 278 files changed (>50 → CRITICAL)
  • 7 modules touched (5-8 → HIGH)
  • 184 files deleted (>10 → CRITICAL)

📦 Modules Affected

ci-workflows (3 files)
  • .github/agents/squad.agent.md
  • .github/skills/iterative-retrieval/SKILL.md
  • .github/skills/reflect/SKILL.md
root (11 files)
  • .changeset/calm-casts-preserve-support.md
  • meet-the-squad.md
  • templates/fact-checker-charter.md
  • templates/rai-charter.md
  • templates/ralph-charter.md
  • templates/roster.md
  • templates/scribe-charter.md
  • templates/squad.agent.md.template
  • workflows/shared/builtins/fact-checker-charter.md
  • workflows/shared/builtins/rai-charter.md
  • workflows/shared/builtins/scribe-charter.md
squad-cli (8 files)
  • packages/squad-cli/src/cli/core/cast.ts
  • packages/squad-cli/src/cli/core/templates.ts
  • packages/squad-cli/templates/fact-checker-charter.md
  • packages/squad-cli/templates/rai-charter.md
  • packages/squad-cli/templates/ralph-charter.md
  • packages/squad-cli/templates/roster.md
  • packages/squad-cli/templates/scribe-charter.md
  • packages/squad-cli/templates/squad.agent.md.template
squad-sdk (6 files)
  • packages/squad-sdk/templates/fact-checker-charter.md
  • packages/squad-sdk/templates/rai-charter.md
  • packages/squad-sdk/templates/ralph-charter.md
  • packages/squad-sdk/templates/roster.md
  • packages/squad-sdk/templates/scribe-charter.md
  • packages/squad-sdk/templates/squad.agent.md.template
squad-state (238 files)
  • .squad/.first-run
  • .squad/agents/_alumni/baer/charter.md
  • .squad/agents/_alumni/breedan/charter.md
  • .squad/agents/_alumni/cheritto/charter.md
  • .squad/agents/_alumni/drucker/charter.md
  • .squad/agents/_alumni/edie/charter.md
  • .squad/agents/_alumni/fenster/charter.md
  • .squad/agents/_alumni/fortier/charter.md
  • .squad/agents/_alumni/hockney/charter.md
  • .squad/agents/_alumni/keaton/charter.md
  • .squad/agents/_alumni/kobayashi/charter.md
  • .squad/agents/_alumni/kobayashi/history.md
  • .squad/agents/_alumni/kovash/charter.md
  • .squad/agents/_alumni/kujan/charter.md
  • .squad/agents/_alumni/marquez/charter.md
  • .squad/agents/_alumni/mcmanus/charter.md
  • .squad/agents/_alumni/nate/charter.md
  • .squad/agents/_alumni/rabin/charter.md
  • .squad/agents/_alumni/redfoot/charter.md
  • .squad/agents/_alumni/saul/charter.md
  • .squad/agents/_alumni/strausz/charter.md
  • .squad/agents/_alumni/trejo/charter.md
  • .squad/agents/_alumni/verbal/charter.md
  • .squad/agents/_alumni/waingro/charter.md
  • .squad/agents/agent-orchestration-dev/charter.md
  • .squad/agents/agentic-workflows-dev/charter.md
  • .squad/agents/architect/charter.md
  • .squad/agents/booster/charter.md
  • .squad/agents/booster/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/booster/history.md
  • .squad/agents/capcom/charter.md
  • .squad/agents/capcom/history.md
  • .squad/agents/cli-dev/charter.md
  • .squad/agents/control/charter.md
  • .squad/agents/control/history.md
  • .squad/agents/docs-devrel/charter.md
  • .squad/agents/dotnet-agent-framework-dev/charter.md
  • .squad/agents/dsky/charter.md
  • .squad/agents/eecom/charter.md
  • .squad/agents/eecom/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/eecom/history-archive-2026-08-20T11-59-44-0700.md
  • .squad/agents/eecom/history.md
  • .squad/agents/fact-checker/charter.md
  • .squad/agents/fido/charter.md
  • .squad/agents/fido/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/fido/history.md
  • .squad/agents/flight/charter.md
  • .squad/agents/flight/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/flight/history.md
  • .squad/agents/git-specialist/charter.md
  • .squad/agents/github-integration-dev/charter.md
  • .squad/agents/gnc/charter.md
  • .squad/agents/gnc/history.md
  • .squad/agents/guido/charter.md
  • .squad/agents/handbook/charter.md
  • .squad/agents/handbook/history.md
  • .squad/agents/inco/charter.md
  • .squad/agents/inco/history.md
  • .squad/agents/integration-e2e-tester/charter.md
  • .squad/agents/network/charter.md
  • .squad/agents/network/history.md
  • .squad/agents/observability-dev/charter.md
  • .squad/agents/pao/charter.md
  • .squad/agents/pao/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/pao/history-archive-2026-08-20T11-59-44-0700.md
  • .squad/agents/pao/history.md
  • .squad/agents/plugin-platform-dev/charter.md
  • .squad/agents/procedures/charter.md
  • .squad/agents/procedures/history-archive-2026-08-19T13-11-34.130-07-00.md
  • .squad/agents/procedures/history-archive-2026-08-20T11-59-44-0700.md
  • .squad/agents/procedures/history.md
  • .squad/agents/rai/charter.md
  • .squad/agents/ralph/charter.md
  • .squad/agents/ralph/history.md
  • .squad/agents/release-engineer/charter.md
  • .squad/agents/retro/charter.md
  • .squad/agents/retro/history.md
  • .squad/agents/scribe/charter.md
  • .squad/agents/scribe/history.md
  • .squad/agents/sdk-runtime-dev/charter.md
  • .squad/agents/security-reviewer/charter.md
  • .squad/agents/sims/charter.md
  • .squad/agents/sims/history.md
  • .squad/agents/state-storage-dev/charter.md
  • .squad/agents/surgeon/charter.md
  • .squad/agents/surgeon/history.md
  • .squad/agents/telemetry/charter.md
  • .squad/agents/terminal-ux-dev/charter.md
  • .squad/agents/typescript-api-contract-designer/charter.md
  • .squad/agents/unit-contract-tester/charter.md
  • .squad/agents/vox/charter.md
  • .squad/agents/vox/history.md
  • .squad/casting-history.json
  • .squad/casting-policy.json
  • .squad/casting-registry.json
  • .squad/casting/history.json
  • .squad/casting/policy.json
  • .squad/casting/registry.json
  • .squad/ceremonies.md
  • .squad/charter.md
  • .squad/commit-message.txt
  • .squad/commit-msg.txt
  • .squad/comms/.gitignore
  • .squad/comms/README.md
  • .squad/comms/templates/audit-entry.md
  • .squad/comms/templates/review-state-schema.sql
  • .squad/comms/templates/tone-validation.json
  • .squad/comms/tests/ci-gate.md
  • .squad/comms/tests/tone-validation-spec.md
  • .squad/config.json
  • .squad/constraint-tracking.md
  • .squad/copilot-instructions.md
  • .squad/decisions-archive.md
  • .squad/decisions.md
  • .squad/e2e/E1-merge-continuation-relay.md
  • .squad/e2e/E4-agent-binding-verification.md
  • .squad/e2e/README.md
  • .squad/e2e/windows-test-baseline.md
  • .squad/fact-checker/policy.md
  • .squad/governance.md
  • .squad/history.md
  • .squad/hooks/README.md
  • .squad/hooks/dispatch-audit.ps1
  • .squad/hooks/dispatch-audit.sh
  • .squad/hooks/tests/compliant.jsonl
  • .squad/hooks/tests/criterion1-triggered.jsonl
  • .squad/hooks/tests/criterion2-triggered.jsonl
  • .squad/hooks/tests/criterion3-triggered.jsonl
  • .squad/hooks/tests/malformed.jsonl
  • .squad/hooks/tests/mixed-with-verdicts.jsonl
  • .squad/hooks/tests/run-tests.ps1
  • .squad/hooks/tests/run-tests.sh
  • .squad/identity/now.md
  • .squad/identity/prd-consult-mode.md
  • .squad/identity/prd-next-waves.md
  • .squad/identity/prd-sdk-init-shoreup.md
  • .squad/identity/sdk-init-implementation-roadmap.md
  • .squad/identity/sdk-init-technical-analysis.md
  • .squad/identity/sdk-init-umbrella-issue.md
  • .squad/identity/wisdom.md
  • .squad/log/2026-03-25T18-11-work-session.md
  • .squad/log/2026-03-26T17-09-631-investigation.md
  • .squad/log/2026-03-27T21-42-00Z-decisions-archival.md
  • .squad/log/2026-07-24T09-20-10-pr-merge-strategy.md
  • .squad/log/2026-08-22T17-10-52-07-00-gh-aw-triage.md
  • .squad/log/2026-08-22T18-25-00-07-00-1793-crlf-merged.md
  • .squad/log/2026-08-22T19-42-25-0700-gh-aw-wave-1.md
  • .squad/log/2026-08-22T21-20-17-0700-1812-roster-binding.md
  • .squad/manifest.json
  • .squad/manifest.schema.json
  • .squad/mcp-config.md
  • .squad/memory/audit.jsonl
  • .squad/memory/config.json
  • .squad/memory/index.json
  • .squad/multi-agent-format.md
  • .squad/onboarding.md
  • .squad/orchestration-log.md
  • .squad/orchestration-log/2026-03-25T18-11-CAPCOM.md
  • .squad/orchestration-log/2026-03-25T18-11-EECOM.md
  • .squad/orchestration-log/2026-03-25T18-11-Flight.md
  • .squad/orchestration-log/2026-03-25T18-11-GNC.md
  • .squad/orchestration-log/2026-03-25T18-11-PAO.md
  • .squad/orchestration-log/2026-03-25T18-11-Procedures.md
  • .squad/orchestration-log/2026-03-26T17-09-investigation-631.md
  • .squad/orchestration-log/2026-07-24T09-20-10.011-00-00-FIDO.md
  • .squad/orchestration-log/2026-07-24T09-20-10.011-00-00-Flight.md
  • .squad/orchestration-log/2026-07-24T09-20-10.011-00-00-RETRO.md
  • .squad/orchestration-log/2026-07-24T09-20-10.011-00-00-Surgeon.md
  • .squad/orchestration-log/2026-08-22T17-10-52-07-00-booster.md
  • .squad/orchestration-log/2026-08-22T17-10-52-07-00-eecom.md
  • .squad/orchestration-log/2026-08-22T17-10-52-07-00-flight.md
  • .squad/orchestration-log/2026-08-22T17-10-52-07-00-procedures.md
  • .squad/orchestration-log/2026-08-22T18-25-00-07-00-EECOM.md
  • .squad/orchestration-log/2026-08-22T18-25-00-07-00-FIDO.md
  • .squad/orchestration-log/2026-08-22T19-42-25-0700-eecom.md
  • .squad/orchestration-log/2026-08-22T19-42-25-0700-fido.md
  • .squad/orchestration-log/2026-08-22T19-42-25-0700-procedures.md
  • .squad/orchestration-log/2026-08-22T19-42-25-0700-retro.md
  • .squad/orchestration-log/2026-08-22T21-20-17-0700-fido.md
  • .squad/orchestration-log/2026-08-22T21-20-17-0700-procedures.md
  • .squad/plugin-marketplace.md
  • .squad/proposals/coordinator-restraint.md
  • .squad/proposals/prompt-architecture-analysis.md
  • .squad/rai/policy.md
  • .squad/ralph-instructions.md
  • .squad/raw-agent-output.md
  • .squad/roster.md
  • .squad/routing.md
  • .squad/run-output.md
  • .squad/scribe-charter.md
  • .squad/sessions/2026-03-01T20-12-48Z_fdc8d707-7d36-4b23-abd9-80b6558f7673.json
  • .squad/sessions/2026-03-04T16-20-51Z_e90fb146-17b4-4d72-a4c5-933ea5946b3f.json
  • .squad/skill.md
  • .squad/skills/coordinator-init-mode/SKILL.md
  • .squad/skills/coordinator-response-mode/SKILL.md
  • .squad/skills/coordinator-source-of-truth/SKILL.md
  • .squad/skills/cross-machine-coordination/SKILL.md
  • .squad/skills/cross-squad-communication/SKILL.md
  • .squad/skills/cross-squad/SKILL.md
  • .squad/skills/dispatchguard/SKILL.md
  • .squad/skills/economy-mode/SKILL.md
  • .squad/skills/external-comms/SKILL.md
  • .squad/skills/fact-checking/SKILL.md
  • .squad/skills/gh-auth-isolation/SKILL.md
  • .squad/skills/gh-aw-enlistment/SKILL.md
  • .squad/skills/humanizer/SKILL.md
  • .squad/skills/model-selection/SKILL.md
  • .squad/skills/personal-squad/SKILL.md
  • .squad/skills/pr-review-response/SKILL.md
  • .squad/skills/pr-screenshots/SKILL.md
  • .squad/skills/ralph-two-pass-scan/SKILL.md
  • .squad/skills/release-process/SKILL.md
  • .squad/skills/session-recovery/SKILL.md
  • .squad/skills/squad-commands/SKILL.md
  • .squad/skills/squad-help/SKILL.md
  • .squad/skills/squad-version-check/SKILL.md
  • .squad/skills/squad/SKILL.md
  • .squad/skills/team-memory-maintenance/SKILL.md
  • .squad/skills/tiered-memory/SKILL.md
  • .squad/skills/versioning-policy/SKILL.md
  • .squad/skills/work-monitoring/SKILL.md
  • .squad/team.md
  • .squad/templates/README.md
  • .squad/templates/agents/challenger.md
  • .squad/templates/ceremonies.md
  • .squad/templates/charter.md
  • .squad/templates/copilot-instructions.md
  • .squad/templates/history.md
  • .squad/templates/human-members.md
  • .squad/templates/issue-lifecycle.md
  • .squad/templates/mcp-config.md
  • .squad/templates/orchestration-log.md
  • .squad/templates/plugin-marketplace.md
  • .squad/templates/ralph-reference.md
  • .squad/templates/roster.md
  • .squad/templates/routing.md
  • .squad/templates/scribe-charter.md
  • .squad/triage/first-run-ux-issues.md
templates (6 files)
  • .squad-templates/fact-checker-charter.md
  • .squad-templates/rai-charter.md
  • .squad-templates/ralph-charter.md
  • .squad-templates/roster.md
  • .squad-templates/scribe-charter.md
  • .squad-templates/squad.agent.md
tests (6 files)
  • test/cast-parser.test.ts
  • test/ci/datetime-template.test.ts
  • test/ci/parallel-spawn-warning.test.ts
  • test/ci/scribe-template.test.ts
  • test/fact-checker-role.test.ts
  • test/init.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Squad File Leakage Detected

The following .squad/ files were modified in this PR:

  • .squad/.first-run
  • .squad/agents/agent-orchestration-dev/charter.md
  • .squad/agents/agentic-workflows-dev/charter.md
  • .squad/agents/architect/charter.md
  • .squad/agents/cli-dev/charter.md
  • .squad/agents/docs-devrel/charter.md
  • .squad/agents/dotnet-agent-framework-dev/charter.md
  • .squad/agents/fact-checker/charter.md
  • .squad/agents/git-specialist/charter.md
  • .squad/agents/github-integration-dev/charter.md
  • .squad/agents/integration-e2e-tester/charter.md
  • .squad/agents/observability-dev/charter.md
  • .squad/agents/plugin-platform-dev/charter.md
  • .squad/agents/rai/charter.md
  • .squad/agents/ralph/charter.md
  • .squad/agents/release-engineer/charter.md
  • .squad/agents/scribe/charter.md
  • .squad/agents/sdk-runtime-dev/charter.md
  • .squad/agents/security-reviewer/charter.md
  • .squad/agents/state-storage-dev/charter.md
  • .squad/agents/terminal-ux-dev/charter.md
  • .squad/agents/typescript-api-contract-designer/charter.md
  • .squad/agents/unit-contract-tester/charter.md
  • .squad/casting/history.json
  • .squad/casting/policy.json
  • .squad/casting/registry.json
  • .squad/ceremonies.md
  • .squad/config.json
  • .squad/decisions.md
  • .squad/fact-checker/policy.md
  • .squad/governance.md
  • .squad/identity/now.md
  • .squad/identity/wisdom.md
  • .squad/memory/audit.jsonl
  • .squad/memory/config.json
  • .squad/memory/index.json
  • .squad/onboarding.md
  • .squad/rai/policy.md
  • .squad/ralph-instructions.md
  • .squad/routing.md
  • .squad/skills/model-selection/SKILL.md
  • .squad/skills/team-memory-maintenance/SKILL.md
  • .squad/skills/work-monitoring/SKILL.md
  • .squad/team.md
  • .squad/templates/ceremonies.md
  • .squad/templates/charter.md
  • .squad/templates/copilot-instructions.md
  • .squad/templates/issue-lifecycle.md
  • .squad/templates/mcp-config.md
  • .squad/templates/plugin-marketplace.md
  • .squad/templates/ralph-reference.md
  • .squad/templates/roster.md
  • .squad/templates/routing.md
  • .squad/templates/scribe-charter.md

These files affect team routing, agent charters, and decisions.
If intentional, ensure approval from the team lead.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Review tier: Lite
Findings: 8 High severity · 2 Medium severity

Open findings (10)
What changed in this PR

Recasts repository-local Squad state around 18 descriptive specialists and bounded support identities.

Changes:

  • Adds descriptive roster, routing, governance, and deferred onboarding.
  • Regenerates casting state and installs coordination skills.
  • Removes obsolete histories, hooks, logs, and superseded team artifacts.
File Description
meet-the-squad.md Updated as part of this pull request.
.squad/​templates/​routing.md Updated as part of this pull request.
.squad/​templates/​roster.md Updated as part of this pull request.
.squad/​templates/​plugin-marketplace.md Updated as part of this pull request.
.squad/​templates/​orchestration-log.md Updated as part of this pull request.
.squad/​templates/​mcp-config.md Updated as part of this pull request.
.squad/​templates/​issue-lifecycle.md Updated as part of this pull request.
.squad/​templates/​human-members.md Updated as part of this pull request.
.squad/​templates/​history.md Updated as part of this pull request.
.squad/​templates/​copilot-instructions.md Updated as part of this pull request.
.squad/​templates/​charter.md Updated as part of this pull request.
.squad/​templates/​ceremonies.md Updated as part of this pull request.
.squad/​templates/​agents/​challenger.md Updated as part of this pull request.
.squad/​skills/​work-monitoring/​SKILL.md Updated as part of this pull request.
.squad/​skills/​squad-help/​SKILL.md Updated as part of this pull request.
.squad/​skills/​ralph-two-pass-scan/​SKILL.md Updated as part of this pull request.
.squad/​skills/​personal-squad/​SKILL.md Updated as part of this pull request.
.squad/​skills/​humanizer/​SKILL.md Updated as part of this pull request.
.squad/​skills/​fact-checking/​SKILL.md Updated as part of this pull request.
.squad/​skills/​dispatchguard/​SKILL.md Updated as part of this pull request.
.squad/​skill.md Updated as part of this pull request.
.squad/​sessions/​2026-03-04T16-20-51Z_e90fb146-17b4-4d72-a4c5-933ea5946b3f.json Updated as part of this pull request.
.squad/​sessions/​2026-03-01T20-12-48Z_fdc8d707-7d36-4b23-abd9-80b6558f7673.json Updated as part of this pull request.
.squad/​run-output.md Updated as part of this pull request.
.squad/​roster.md Updated as part of this pull request.
.squad/​raw-agent-output.md Updated as part of this pull request.
.squad/​ralph-instructions.md Updated as part of this pull request.
.squad/​rai/​policy.md Updated as part of this pull request.
.squad/​plugin-marketplace.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T21-20-17-0700-procedures.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T21-20-17-0700-fido.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T19-42-25-0700-retro.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T19-42-25-0700-procedures.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T19-42-25-0700-fido.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T19-42-25-0700-eecom.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T18-25-00-07-00-FIDO.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T18-25-00-07-00-EECOM.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T17-10-52-07-00-procedures.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T17-10-52-07-00-flight.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T17-10-52-07-00-eecom.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-08-22T17-10-52-07-00-booster.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-07-24T09-20-10.011-00-00-Surgeon.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-07-24T09-20-10.011-00-00-RETRO.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-07-24T09-20-10.011-00-00-Flight.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-07-24T09-20-10.011-00-00-FIDO.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-26T17-09-investigation-631.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-Procedures.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-PAO.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-GNC.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-Flight.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-EECOM.md Updated as part of this pull request.
.squad/​orchestration-log/​2026-03-25T18-11-CAPCOM.md Updated as part of this pull request.
.squad/​orchestration-log.md Updated as part of this pull request.
.squad/​onboarding.md Updated as part of this pull request.
.squad/​multi-agent-format.md Updated as part of this pull request.
.squad/​memory/​index.json Updated as part of this pull request.
.squad/​memory/​config.json Updated as part of this pull request.
.squad/​memory/​audit.jsonl Updated as part of this pull request.
.squad/​mcp-config.md Updated as part of this pull request.
.squad/​manifest.schema.json Updated as part of this pull request.
.squad/​manifest.json Updated as part of this pull request.
.squad/​log/​2026-08-22T21-20-17-0700-1812-roster-binding.md Updated as part of this pull request.
.squad/​log/​2026-08-22T19-42-25-0700-gh-aw-wave-1.md Updated as part of this pull request.
.squad/​log/​2026-08-22T18-25-00-07-00-1793-crlf-merged.md Updated as part of this pull request.
.squad/​log/​2026-08-22T17-10-52-07-00-gh-aw-triage.md Updated as part of this pull request.
.squad/​log/​2026-07-24T09-20-10-pr-merge-strategy.md Updated as part of this pull request.
.squad/​log/​2026-03-27T21-42-00Z-decisions-archival.md Updated as part of this pull request.
.squad/​log/​2026-03-26T17-09-631-investigation.md Updated as part of this pull request.
.squad/​identity/​wisdom.md Updated as part of this pull request.
.squad/​identity/​sdk-init-umbrella-issue.md Updated as part of this pull request.
.squad/​identity/​prd-next-waves.md Updated as part of this pull request.
.squad/​identity/​now.md Updated as part of this pull request.
.squad/​hooks/​tests/​mixed-with-verdicts.jsonl Updated as part of this pull request.
.squad/​hooks/​tests/​malformed.jsonl Updated as part of this pull request.
.squad/​hooks/​tests/​criterion3-triggered.jsonl Updated as part of this pull request.
.squad/​hooks/​tests/​criterion2-triggered.jsonl Updated as part of this pull request.
.squad/​hooks/​tests/​criterion1-triggered.jsonl Updated as part of this pull request.
.squad/​hooks/​tests/​compliant.jsonl Updated as part of this pull request.
.squad/​history.md Updated as part of this pull request.
.squad/​governance.md Updated as part of this pull request.
.squad/​copilot-instructions.md Updated as part of this pull request.
.squad/​constraint-tracking.md Updated as part of this pull request.
.squad/​config.json Updated as part of this pull request.
.squad/​comms/​tests/​ci-gate.md Updated as part of this pull request.
.squad/​comms/​templates/​review-state-schema.sql Updated as part of this pull request.
.squad/​comms/​templates/​audit-entry.md Updated as part of this pull request.
.squad/​comms/​README.md Updated as part of this pull request.
.squad/​comms/​.gitignore Updated as part of this pull request.
.squad/​commit-msg.txt Updated as part of this pull request.
.squad/​commit-message.txt Updated as part of this pull request.
.squad/​charter.md Updated as part of this pull request.
.squad/​ceremonies.md Updated as part of this pull request.
.squad/​casting/​policy.json Updated as part of this pull request.
.squad/​casting/​history.json Updated as part of this pull request.
.squad/​casting-registry.json Updated as part of this pull request.
.squad/​casting-policy.json Updated as part of this pull request.
.squad/​casting-history.json Updated as part of this pull request.
.squad/​agents/​vox/​history.md Updated as part of this pull request.
.squad/​agents/​vox/​charter.md Updated as part of this pull request.
.squad/​agents/​unit-contract-tester/​charter.md Updated as part of this pull request.
.squad/​agents/​typescript-api-contract-designer/​charter.md Updated as part of this pull request.
.squad/​agents/​terminal-ux-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​telemetry/​charter.md Updated as part of this pull request.
.squad/​agents/​surgeon/​charter.md Updated as part of this pull request.
.squad/​agents/​state-storage-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​sims/​history.md Updated as part of this pull request.
.squad/​agents/​sims/​charter.md Updated as part of this pull request.
.squad/​agents/​security-reviewer/​charter.md Updated as part of this pull request.
.squad/​agents/​sdk-runtime-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​scribe/​history.md Updated as part of this pull request.
.squad/​agents/​scribe/​charter.md Updated as part of this pull request.
.squad/​agents/​retro/​history.md Updated as part of this pull request.
.squad/​agents/​retro/​charter.md Updated as part of this pull request.
.squad/​agents/​release-engineer/​charter.md Updated as part of this pull request.
.squad/​agents/​ralph/​history.md Updated as part of this pull request.
.squad/​agents/​ralph/​charter.md Updated as part of this pull request.
.squad/​agents/​rai/​charter.md Updated as part of this pull request.
.squad/​agents/​procedures/​charter.md Updated as part of this pull request.
.squad/​agents/​plugin-platform-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​pao/​charter.md Updated as part of this pull request.
.squad/​agents/​observability-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​network/​history.md Updated as part of this pull request.
.squad/​agents/​network/​charter.md Updated as part of this pull request.
.squad/​agents/​integration-e2e-tester/​charter.md Updated as part of this pull request.
.squad/​agents/​inco/​history.md Updated as part of this pull request.
.squad/​agents/​inco/​charter.md Updated as part of this pull request.
.squad/​agents/​handbook/​history.md Updated as part of this pull request.
.squad/​agents/​handbook/​charter.md Updated as part of this pull request.
.squad/​agents/​guido/​charter.md Updated as part of this pull request.
.squad/​agents/​gnc/​history.md Updated as part of this pull request.
.squad/​agents/​gnc/​charter.md Updated as part of this pull request.
.squad/​agents/​github-integration-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​git-specialist/​charter.md Updated as part of this pull request.
.squad/​agents/​flight/​charter.md Updated as part of this pull request.
.squad/​agents/​fido/​history.md Updated as part of this pull request.
.squad/​agents/​fido/​charter.md Updated as part of this pull request.
.squad/​agents/​fact-checker/​charter.md Updated as part of this pull request.
.squad/​agents/​eecom/​charter.md Updated as part of this pull request.
.squad/​agents/​dsky/​charter.md Updated as part of this pull request.
.squad/​agents/​dotnet-agent-framework-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​docs-devrel/​charter.md Updated as part of this pull request.
.squad/​agents/​control/​history.md Updated as part of this pull request.
.squad/​agents/​control/​charter.md Updated as part of this pull request.
.squad/​agents/​cli-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​capcom/​charter.md Updated as part of this pull request.
.squad/​agents/​booster/​charter.md Updated as part of this pull request.
.squad/​agents/​architect/​charter.md Updated as part of this pull request.
.squad/​agents/​agentic-workflows-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​agent-orchestration-dev/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​waingro/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​verbal/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​strausz/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​saul/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​redfoot/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​rabin/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​nate/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​mcmanus/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​marquez/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​kujan/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​kovash/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​kobayashi/​history.md Updated as part of this pull request.
.squad/​agents/​_alumni/​keaton/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​hockney/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​fortier/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​fenster/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​edie/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​cheritto/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​breedan/​charter.md Updated as part of this pull request.
.squad/​agents/​_alumni/​baer/​charter.md Updated as part of this pull request.
.squad/​.first-run Updated as part of this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/agents/squad.agent.md Resolved
Comment thread .github/agents/squad.agent.md Resolved
Comment thread .squad/agents/fact-checker/charter.md Resolved
Comment thread .squad/agents/rai/charter.md Resolved
Comment thread .squad/agents/scribe/charter.md Resolved
Comment thread .squad/agents/scribe/charter.md Resolved
Comment thread .squad/routing.md Resolved
Comment thread .squad/team.md Resolved
Comment thread .squad/team.md Resolved
Comment thread .squad/templates/roster.md Resolved
bradygaster and others added 2 commits September 12, 2026 23:31
Keep support identities separate, retain the Coding Agent contract, align canonical built-ins and coordinator templates, and stop recreating retired histories.\n\nPart of #2009\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Comment on lines +529 to +536
Parallel dispatch is allowed only when the request contains independently deliverable outcomes
that route to different accountable specialists. For a single outcome:

Warn once per session, then proceed — this is a caution, not a gate.
1. Select exactly one accountable specialist from `.squad/routing.md`.
2. Give that owner the complete task and required evidence.
3. Add a contributor only for a concrete, bounded subproblem the owner cannot cover.
4. Add a reviewer only when the active team or repository policy requires a material-risk gate.
5. Do not launch speculative, anticipatory, or merely potentially useful agents.
## Ralph, Go!

Read this file for your full instructions. Follow ALL sections.
MAXIMIZE PARALLELISM — spawn agents for ALL actionable issues simultaneously.
filesCreated.push(teamPath);
}

// Create or update routing.md
const routingPath = join(squadDir, 'routing.md');
const routingTable = buildRoutingTable(allMembers);
const routingTable = buildRoutingTable(specialistMembers);
Comment thread test/cast-parser.test.ts
Comment on lines +261 to +265
for (const builtin of ['Scribe', 'Ralph', 'Rai', 'Fact Checker']) {
expect(members).not.toContain(`| ${builtin} |`);
expect(support).toContain(`| ${builtin} |`);
expect(routing).not.toMatch(new RegExp(`\\|[^\\n]*\\| ${builtin} \\|`));
}
Comment on lines +36 to +44
expect(collaboration).toContain('exactly one accountable specialist');
expect(collaboration).toContain('independently deliverable outcomes');
expect(collaboration).toContain('concrete, bounded subproblem');
expect(collaboration).toContain('Do not launch speculative, anticipatory');
expect(collaboration).toContain('**Shared-worktree guard.**');
expect(collaboration).toContain('2+ background agents');
expect(collaboration).toContain('Pre-Spawn: Worktree Setup');
expect(collaboration).toContain('untracked files');
expect(collaboration).toContain('warning is a caution');
Comment on lines +66 to +71
it('defines bounded activation instead of automatic review fan-out', () => {
const content = readFileSync(templatePath, 'utf-8');
expect(content).toContain('## When I\'m Triggered');
expect(content).toContain('fact-check');
expect(content).toContain('## Activation');
expect(content).toContain('Explicit user request');
expect(content).toContain('There is no automatic pre-publish, post-research, or routing-triggered review.');
expect(content).toContain('at most two high-risk gates');
Comment thread test/init.test.ts
Comment on lines +259 to +263
// The bounded support charter keeps the policy source but must not
// recreate the retired audit-log contract.
expect(charter).toMatch(/\.squad\/rai\/policy\.md/);
expect(charter).toMatch(/\.squad\/rai\/audit-trail\.md/);
expect(charter).toMatch(/does not create audit logs/i);
expect(charter).not.toMatch(/\.squad\/rai\/audit-trail\.md/);
@bradygaster
bradygaster merged commit 8b79211 into dev Sep 13, 2026
20 checks passed
@bradygaster
bradygaster deleted the bradygaster-recast-descriptive-squad branch October 3, 2026 00:11
joslat added a commit to joslat/squad that referenced this pull request Oct 25, 2026
Since github#2030 Scribe's charter says it only merges accepted decisions, and the
coordinator's inline Scribe template matches it. Other shipped surfaces still
gave Scribe the old broad job: the after-agent reference (archive hard gate,
session and orchestration logs, cross-agent history appends, history
summarization), the host coordinator digest, the decision-hygiene watch
prompt, the spawn reference (skill extraction), routing, ceremony and
model-selection references, several skills and docs.

Align all of them with the charter, make the after-agent Scribe prompt
identical to the inline template, point size hygiene at `squad nap`, and add
cross-surface guard tests so retired duties can't come back.

Closes github#2321
joslat added a commit to joslat/squad that referenced this pull request Oct 26, 2026
Since github#2030 Scribe's charter says it only merges accepted decisions, and the
coordinator's inline Scribe template matches it. Other shipped surfaces still
gave Scribe the old broad job: the after-agent reference (archive hard gate,
session and orchestration logs, cross-agent history appends, history
summarization), the host coordinator digest, the decision-hygiene watch
prompt, the spawn reference (skill extraction), routing, ceremony and
model-selection references, several skills and docs.

Align all of them with the charter, make the after-agent Scribe prompt
identical to the inline template, point size hygiene at `squad nap`, and add
cross-surface guard tests so retired duties can't come back.

The charter's "Exclusive canonical artifacts" paragraph no longer names a
session log or a retrospective as something Scribe creates (all copies,
including the gh-aw builtin and its manifest digest).

Closes github#2321
joslat added a commit to joslat/squad that referenced this pull request Nov 10, 2026
Since github#2030 Scribe's charter says it only merges accepted decisions, and the
coordinator's inline Scribe template matches it. Other shipped surfaces still
gave Scribe the old broad job: the after-agent reference (archive hard gate,
session and orchestration logs, cross-agent history appends, history
summarization), the host coordinator digest, the decision-hygiene watch
prompt, the spawn reference (skill extraction), routing, ceremony and
model-selection references, several skills and docs.

Align all of them with the charter, make the after-agent Scribe prompt
identical to the inline template, point size hygiene at `squad nap`, and add
cross-surface guard tests so retired duties can't come back.

The charter's "Exclusive canonical artifacts" paragraph no longer names a
session log or a retrospective as something Scribe creates (all copies,
including the gh-aw builtin and its manifest digest).

Closes github#2321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants