Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8dd55540-3d6b-43a8-873a-7d22380d548f
eca683d to
7862a67
Compare
paldepind
changed the title
borrow, consume, copy, and unsafe expressions
There was a problem hiding this comment.
🟡 Changes recommended
The new Swift unary operators lack operand value propagation in unified data flow, causing flows through borrow, consume, copy, and unsafe to stop at the wrapper and leaving a gap in security analyses.
1 open issue
What changed in this PR
Adds unified Swift extraction support for borrow, consume, copy, and unsafe, representing them as unary expressions like await and try.
Changes:
- Adds translation rules that preserve each keyword as a prefix operator and translate its operand.
- Removes the corresponding unsupported-node mappings.
- Adds a borrow fixture and updates expected output for all four expressions.
| File | Description |
|---|---|
unified/extractor/tests/corpus/swift/expressions/unsafe-expression.output |
Expects a unary expression wrapping the call. |
unified/extractor/tests/corpus/swift/expressions/copy-expression.output |
Expects a copy unary expression. |
unified/extractor/tests/corpus/swift/expressions/consume-expression.output |
Expects a consume unary expression. |
unified/extractor/tests/corpus/swift/expressions/borrow-expression.swift |
Adds a basic borrow-expression fixture. |
unified/extractor/tests/corpus/swift/expressions/borrow-expression.output |
Records the borrow fixture’s expected syntax trees. |
unified/extractor/src/languages/swift/swift.rs |
Adds the four unary-expression translation rules. |
Review effort: Balanced (auto)
| rule!((awaitExpr awaitKeyword: @@keyword expression: @val) => (unary_expr | ||
| operator: (prefix_operator "await" location: {keyword}) | ||
| operand: {val})), | ||
| rule!((borrowExpr borrowKeyword: @@keyword expression: @val) => (unary_expr |
There was a problem hiding this comment.
I think that's outside the scope of this PR but I'd like to take a look at that afterwards once we've agreed that this is how we'll map these construct to the common AST.
There was a problem hiding this comment.
The UnaryExpr representation is the way to go 👍
It would be great if you could update type inference and data flow in this PR.
In general I'd like a chunk of work to own an entire language feature across all layers, unless it's impractical for some reason. (In Q1 we worked layer-by-layer for a fixed subset of features in order to bootstrap, but I want to move away from that).
Just like how
awaitandtryare mapped tounary_exprthis PR does the same forborrow,consume,copy, andunsafeexpressions.