Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The conversion is represented across the manifests and replacement JSON extensions, with review identifying only non-blocking documentation-link nits.
No open issues 🎉
What changed in this PR
Converts the shared CodeQL utility and threat-model data extensions from YAML to JSON for faster loading in CodeQL CLI 2.27.3 while preserving the existing extension data.
Changes:
- Registers JSON data extensions in the shared utility and threat-model pack manifests.
- Replaces the default alert-filter YAML extension with JSON.
- Replaces the threat-model grouping and supported-threat-model YAML extensions with JSON equivalents.
| File | Summary | Review comments |
|---|---|---|
shared/util/qlpack.yml |
Registers JSON utility data extensions. | — |
shared/util/ext/default-alert-filter.yml |
Removes the former YAML alert-filter extension. | — |
shared/util/ext/default-alert-filter.json |
Provides the alert-filter extension in JSON format. | — |
shared/threat-models/qlpack.yml |
Registers JSON threat-model data extensions. | Nit (1 vote): Update five source comments that still link to the deleted threat-model-grouping.model.yml path, including locations in the Rust, JavaScript, and Python Concepts.qll files. |
shared/threat-models/ext/threat-model-grouping.model.yml |
Removes the former YAML threat-model grouping extension. | — |
shared/threat-models/ext/threat-model-grouping.model.json |
Provides threat-model groupings in JSON format. | Nit (1 vote): Update the public Concepts.qll documentation links in the Python, JavaScript, and Rust libraries to reference the JSON path or otherwise preserve valid links. |
shared/threat-models/ext/supported-threat-models.model.yml |
Removes the former YAML supported-model configuration. | — |
shared/threat-models/ext/supported-threat-models.model.json |
Provides the supported-model configuration in JSON format. | — |
Review effort: Lite (auto)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL CLI 2.27.3 supports JSON data extensions (aka MaD models), and can load them significantly faster than YAML. This PR converts those in the
sharedpacks.To verify successful conversion, I cherry-picked this commit onto #23059, which has a temporary test that enumerates all tuples from data extensions. The test still passes after conversion.